Skip to content

Conversation

@lnbc1QWFyb24
Copy link
Contributor

@lnbc1QWFyb24 lnbc1QWFyb24 commented Aug 12, 2022

Description

Moves the check for re-initialization to the top of the function, so that the reset of state does not override new init options.

Fixes #1196

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit 99b4748 into v2-web3-onboard-develop Aug 12, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the fix/re-init-cleanup branch August 12, 2022 03:34
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request Aug 12, 2022
This was referenced Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Error: At least one chain must be set before attempting to connect a wallet

2 participants