Skip to content

Conversation

@mahmud-bn
Copy link
Contributor

Description

This PR separates common packages into two packages. Also, get rids of node-builtins

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few comments but getting close!

@lnbc1QWFyb24
Copy link
Contributor

I have extended the scope of this PR. It now:

  • Moves all hardware wallet related code from the common package to the hw-common package
  • Fixes a validation bug for hardware wallets by extracting all common validation and putting it in the common package. This removes duplicate validation logic that was inconsistent
  • Modifies build script to run serially so that it builds in order necessary for no errors
  • Fixes type issues in the repo

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple version changes for React & Vue packages to keep the pattern of minor bumps for packages with dep changes, yarn.lock changes look a little light as well...?
Other than that great work!

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit 9dd5130 into v2-web3-onboard-develop Aug 17, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the feature/hw-common branch August 17, 2022 23:23
This was referenced Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants