-
Notifications
You must be signed in to change notification settings - Fork 541
[core-v2.7.0-alpha.3, common-v2.1.8-alpha.1, hw-common-v1.0.0-alpha.1, demo-v2.0.8]: Feature -hw common #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adamj1232
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few comments but getting close!
…rd into feature/hw-common
|
I have extended the scope of this PR. It now:
|
Adamj1232
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple version changes for React & Vue packages to keep the pattern of minor bumps for packages with dep changes, yarn.lock changes look a little light as well...?
Other than that great work!
Co-authored-by: Adam Carpenter <[email protected]>
Co-authored-by: Adam Carpenter <[email protected]>
Description
This PR separates common packages into two packages. Also, get rids of node-builtins
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors