-
Notifications
You must be signed in to change notification settings - Fork 541
[core-v2.8.4-alpha.2, react-v2.3.4-alpha.2, vue-v2.2.4-alpha.2] : Enhancement - Improved theme nomenclature #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Adamj1232
merged 39 commits into
v2-web3-onboard-develop
from
enhancement/improved_theme_nomenclature
Sep 19, 2022
Merged
[core-v2.8.4-alpha.2, react-v2.3.4-alpha.2, vue-v2.2.4-alpha.2] : Enhancement - Improved theme nomenclature #1202
Adamj1232
merged 39 commits into
v2-web3-onboard-develop
from
enhancement/improved_theme_nomenclature
Sep 19, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of a different approach
lnbc1QWFyb24
approved these changes
Sep 19, 2022
Contributor
lnbc1QWFyb24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a spelling fix suggestion, but otherwise good to go.
Contributor
Author
@aaronbarnardsound I swear I know how to spell boarder 🏂 lol 🤦♂️ |
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on created variables that will allow for theming along with more customized styling by developers.
In the demo app there is the theming abstraction to be tested with by @gesquinca
Added variables to allow for more in-depth and customized theming.
Added a component to the internal demo to help style that uses a mapping to a smaller subset of variables.
Added variables:
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors