Skip to content

Conversation

@Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented Aug 8, 2022

Description

This PR focuses on created variables that will allow for theming along with more customized styling by developers.
In the demo app there is the theming abstraction to be tested with by @gesquinca
Added variables to allow for more in-depth and customized theming.
Added a component to the internal demo to help style that uses a mapping to a smaller subset of variables.

Added variables:

  --account-center-border
  --account-center-box-shadow
  --account-center-boarder-radius
  --account-center-chain-warning
  --account-center-minimized-balance-color
  --account-center-minimized-chain-select-background
  --account-center-maximized-network-section-background
  --account-center-maximized-network-text-color
  --account-center-maximized-info-section-background-color
  --account-center-maximized-upper-action-color
  --account-center-maximized-upper-action-background-hover
  --account-center-maximized-app-name-color
  --account-center-maximized-app-info-color
  --account-center-micro-background
  
    --notify-onboard-z-index
  --notify-onboard-background
  --notify-onboard-close-icon-color
  --notify-onboard-close-icon-hover
  --notify-onboard-transaction-status-color
  --notify-onboard-transaction-font-size
  --notify-onboard-hash-time-font-size
  --notify-onboard-hash-time-font-line-height
  --notify-onboard-address-hash-color
  --notify-onboard-anchor-color

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 requested a review from gesquinca August 8, 2022 22:39
@Adamj1232 Adamj1232 marked this pull request as ready for review September 13, 2022 17:44
@Adamj1232 Adamj1232 changed the title [core-v2.7.0-alpha.1, react-v2.2.6-alpha.1, vue-v2.1.6-alpha.1] : Enhancement - Improved theme nomenclature [core-v2.8.4-alpha.2, react-v2.3.4-alpha.2, vue-v2.2.4-alpha.2] : Enhancement - Improved theme nomenclature Sep 16, 2022
Copy link
Contributor

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a spelling fix suggestion, but otherwise good to go.

@Adamj1232
Copy link
Contributor Author

Nice! Just a spelling fix suggestion, but otherwise good to go.

@aaronbarnardsound I swear I know how to spell boarder 🏂 lol 🤦‍♂️

@Adamj1232 Adamj1232 merged commit 860fad5 into v2-web3-onboard-develop Sep 19, 2022
@Adamj1232 Adamj1232 deleted the enhancement/improved_theme_nomenclature branch September 19, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants