Skip to content

Conversation

@ihorbond
Copy link
Contributor

@ihorbond ihorbond commented Aug 1, 2022

onboard.state.actions.updateAccountCenter function takes settings object directly, no need for desktop/mobile wrapper otherwise error is thrown

Description

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

onboard.state.actions.updateAccountCenter function takes settings object directly, no need for desktop/mobile wrapper otherwise error is thrown
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, thank you!

@Adamj1232 Adamj1232 merged commit d30a4ad into thirdweb-dev:v2-web3-onboard-develop Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants