[core: 2.6.0-alpha.2] - [fix] - Autoselect with disabled modals resolve #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmud-bn
approved these changes
Jul 20, 2022
This was referenced Jul 27, 2022
Merged
|
这个问题解决了吗？我现在用 @web-onboard/core ^2.21.1 的版本。label 随便填写一个钱包，并不会报错，我没法 catch 到这个错误，以至于我的代码不知道是不是除了问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the call to
connectWalletwould not resolve or reject if called with theautoSelectparameter for a wallet that is no longer available.Fixes #1153
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors