[core: 2.5.0-alpha.1] - [enhancement] - Delayed Wallet Init #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0526972.
taylorjdawson
approved these changes
Jul 14, 2022
Contributor
taylorjdawson
left a comment
taylorjdawson
left a comment
There was a problem hiding this comment.
Nice looks good to me! 🚀
This was referenced Jul 15, 2022
Merged
Contributor
|
I really like this change 🎉 🚀 🎸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the timing of when the wallet initialization code is run from during Onboard init, to when the
connectWalletfunction is first called. This will allow for all async injected wallet modules to be injected in the page before we initialize the wallet modules. This important due to changes enforced to Google extensions in early 2023 which will make all injected wallets have to inject async.In the case of an autoselect wallet flow, we also add an additional small delay to ensure enough time for injection.
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors