Skip to content

Conversation

@monokh
Copy link
Contributor

@monokh monokh commented Jul 5, 2022

Description

For some strange reason, the liquality wallet was being constrained to the arbitrum namespace. As a result, web3 onboard is not able to connect to liquality except for arbitrum.

Liquality supports regular window.ethereum with EIP1993.

This PR fixes this by using window.ethereum as injection namespace

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@Adamj1232
Copy link
Contributor

@monokh thanks for the PR! Could you please increment the version of the injected package within the package.json file to 2.0.13-alpha.1

@monokh
Copy link
Contributor Author

monokh commented Jul 5, 2022

@Adamj1232 Thanks, updated

@Adamj1232 Adamj1232 changed the title fix: liquality wallet injection [injected-v2.0.13-alpha.1] : fix - Liquality wallet injection update Jul 5, 2022
@Adamj1232
Copy link
Contributor

Adamj1232 commented Jul 5, 2022

@monokh We will want the version change within the injected package inside the package.json file and that will be set to 2.0.13-alpha.1
This will allow us to publish an alpha release for testing of this specific package.

@Adamj1232
Copy link
Contributor

@monokh We will want the version change within the injected package inside the package.json file and that will be set to 2.0.13-alpha.1 This will allow us to publish an alpha release for testing of this specific package.

@monokh I cloned your fork and added the version update so we could get this into this weeks release. Thanks for your PR! And dont forget to pull if using this branch any further! 🥂

@Adamj1232 Adamj1232 merged commit fba1270 into thirdweb-dev:v2-web3-onboard-develop Jul 5, 2022
@monokh
Copy link
Contributor Author

monokh commented Jul 5, 2022

@monokh We will want the version change within the injected package inside the package.json file and that will be set to 2.0.13-alpha.1 This will allow us to publish an alpha release for testing of this specific package.

Sorry about that. Thanks for fixing it up

@Adamj1232
Copy link
Contributor

Sorry about that. Thanks for fixing it up
Not a problem at all! Thank you again for the PR! It will be released in a day or two after some testing in our staging but you can use with the current alpha tag if you like

@hellozeck
Copy link

@Adamj1232 Hello,If this fix is already in production ?i met this issue in https://passport.gitcoin.co/#/

@Adamj1232
Copy link
Contributor

@Adamj1232 Hello,If this fix is already in production ?i met this issue in https://passport.gitcoin.co/#/

@hellozeck yessir this is in production. What version of the injected package did you run into this issue?

@lmoose1
Copy link

lmoose1 commented Jul 25, 2022

Hello, I cannot link my Liquality wallet on https://gnosis-safe.io/app, there is no option of Liquality wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants