-
Notifications
You must be signed in to change notification settings - Fork 541
[injected-v2.0.13-alpha.1] : fix - Liquality wallet injection update #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[injected-v2.0.13-alpha.1] : fix - Liquality wallet injection update #1123
Conversation
|
@monokh thanks for the PR! Could you please increment the version of the injected package within the package.json file to |
|
@Adamj1232 Thanks, updated |
|
@monokh We will want the version change within the injected package inside the package.json file and that will be set to 2.0.13-alpha.1 |
@monokh I cloned your fork and added the version update so we could get this into this weeks release. Thanks for your PR! And dont forget to pull if using this branch any further! 🥂 |
Sorry about that. Thanks for fixing it up |
|
|
@Adamj1232 Hello,If this fix is already in production ?i met this issue in https://passport.gitcoin.co/#/ |
@hellozeck yessir this is in production. What version of the injected package did you run into this issue? |
|
Hello, I cannot link my Liquality wallet on https://gnosis-safe.io/app, there is no option of Liquality wallet |
Description
For some strange reason, the liquality wallet was being constrained to the arbitrum namespace. As a result, web3 onboard is not able to connect to liquality except for arbitrum.
Liquality supports regular
window.ethereumwith EIP1993.This PR fixes this by using
window.ethereumas injection namespaceChecklist
package.jsonis incremented following semantic versioning