[core-v2.3.2-alpha.3 , react-v2.2.2-alpha.2, vue-v2.1.2-alpha.2] : Fix - Conditional rendering Notify and Account Center #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
taylorjdawson
approved these changes
Jun 29, 2022
Contributor
taylorjdawson
left a comment
taylorjdawson
left a comment
There was a problem hiding this comment.
@Adamj1232 I am trusting you on that complex boolean logic 😅
This was referenced Jun 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to cleanup Conditional rendering of Notify and Account Center
Fix rendering problem when Notifications are moved into the same container as AccountCenter
Moved stream out of the Notify component for more control on render changes
Pulled render logic out of HTML and into JS and streamline
Checklist
package.jsonis incremented following semantic versioning