Skip to content

[core-v2.3.2-alpha.3 , react-v2.2.2-alpha.2, vue-v2.1.2-alpha.2]: Feature - copy address to clipboard #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 5, 2022
Merged

[core-v2.3.2-alpha.3 , react-v2.2.2-alpha.2, vue-v2.1.2-alpha.2]: Feature - copy address to clipboard #1112

merged 12 commits into from
Jul 5, 2022

Conversation

@mahmud-bn
Copy link
Contributor

@mahmud-bn mahmud-bn commented Jun 29, 2022 •
edited
Loading

Description

Feature requetst: #1028
Screen Shot 2022-07-05 at 5 21 04 PM

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@mahmud-bn mahmud-bn requested a review from taylorjdawson June 29, 2022 21:24
Adamj1232
Adamj1232 reviewed Jun 29, 2022
View reviewed changes
taylorjdawson
taylorjdawson approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@taylorjdawson taylorjdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 😍 🤘🏾

Adamj1232
Adamj1232 reviewed Jul 5, 2022
View reviewed changes
@mahmud-bn mahmud-bn merged commit 7b1e64e into v2-web3-onboard-develop Jul 5, 2022
@mahmud-bn mahmud-bn deleted the feature/copyaddress-clipboard branch July 5, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Adamj1232 Adamj1232 Adamj1232 left review comments

@taylorjdawson taylorjdawson taylorjdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mahmud-bn @Adamj1232 @taylorjdawson