[react-v2.2.1-alpha.3, core-v2.3.1-alpha.3, vue-v2.1.1-alpha.2] : Feature - React hook updates #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…knative/onboard into v2-web3-onboard-develop
…enter, Update OnboardAPI type
…knative/onboard into v2-web3-onboard-develop
taylorjdawson
suggested changes
Jun 23, 2022
Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Taylor Dawson <[email protected]>
Co-authored-by: Taylor Dawson <[email protected]>
Contributor
|
@Adamj1232 This is obvious but all code works if copy and pasted right? just checking 😄 |
Co-authored-by: Taylor Dawson <[email protected]>
…locknative/onboard into feature/react_hook_updates
Contributor
Author
Yes sir! Copied it right out of my testing from the reactdemo project |
Co-authored-by: Taylor Dawson <[email protected]>
Contributor
Author
|
@taylorjdawson I dont know if it would be beneficial but with the OnboardAPI type with action props now we could add functionality to the Vue project if worth while |
taylorjdawson
approved these changes
Jun 23, 2022
This was referenced Jun 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added React hooks for all exposed API actions:
useConnectedWallet
useNotifications
useAccountCenter
useSetLocale
Updated OnboardAPI type to include actions
Checklist
package.jsonis incremented following semantic versioning