Skip to content

[web3-onboard-v2.3.0-alpha.1] : Fix - Notifications build issue #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2022
Merged

[web3-onboard-v2.3.0-alpha.1] : Fix - Notifications build issue #1081

merged 2 commits into from
Jun 20, 2022

Conversation

@Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented Jun 20, 2022 •
edited
Loading

Description

Run yarn and remove path extra on packages within workspaces at top level package.json

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 requested a review from mahmud-bn June 20, 2022 19:09
@Adamj1232 Adamj1232 merged commit 58b3e13 into v2-web3-onboard-develop Jun 20, 2022
@Adamj1232 Adamj1232 deleted the fix/notification_build_issue branch June 20, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mahmud-bn mahmud-bn mahmud-bn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Adamj1232 @mahmud-bn