Skip to content

Conversation

@Adamj1232
Copy link
Contributor

Description

Forgot to run yarn type-check locally before merging
Update types causing build to break

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 requested a review from mahmud-bn June 20, 2022 17:11
@dmarzzz dmarzzz self-requested a review June 20, 2022 17:34
Copy link
Contributor

@dmarzzz dmarzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No semver but other than that LGTM

@Adamj1232 Adamj1232 requested a review from taylorjdawson June 20, 2022 17:34
@Adamj1232 Adamj1232 merged commit 2f4c11d into v2-web3-onboard-develop Jun 20, 2022
@Adamj1232 Adamj1232 deleted the fix/notifications_type_updates branch June 20, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants