[injected-wallets] : update - Coinbase app provider handling by coinbase injected wallet #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmud-bn
approved these changes
May 25, 2022
tokensex
pushed a commit
to tokensex/web3-onboard
that referenced
this pull request
May 30, 2022
…ase injected wallet (thirdweb-dev#1014) * Update handling of coinbase app provider by the coinbase injected provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how the Coinbase injected wallet handles the Coinbase App provider by check at the top level for the CoinbaseExtension flag rather then within the providers array.
Tested on Desktop and Coinbase Wallet App using NGROK
Checklist
package.jsonis incremented following semantic versioning