Wallet not defined when using wallet-connect v-2

[L03TJ3]

Current Behavior

Just tried out to implement the wallet-connect v2-module.
Connecting works (it seems), but after connecting switch request does not seem to work

wallet does not seem to be defined or set properly

• noticed that the chain id is not correctly parsed and has an additional 0x added to it (might be part of issue?)

Expected Behavior

Wallet should be properly set when connected
Chain-id should not be double prefixed

Steps To Reproduce

Steps to reproduce:

1. go to https://good-swap-nxlct9qga-gooddollarteam.vercel.app/
2. open up a gooddollar-wallet at wallet.gooddollar.org
3. connect with wallet-connect (copy link)
4. click on gooddapp on the network button (top-nav)
5. switch to other chain
6. see log (as shared on screen)

Running it with web3-onboard example gives different issue currently, outside scope of this particular bug

definition of wc-module: https://github.com/GoodDollar/GoodWeb3-Mono/blob/7363f1aae6e08631018526f77da1d948130dcbed/packages/sdk-v2/src/sdk/onboard/react.tsx#L66

type definition: https://github.com/GoodDollar/GoodWeb3-Mono/blob/7363f1aae6e08631018526f77da1d948130dcbed/packages/sdk-v2/src/sdk/onboard/modules/customwalletconnect/types.ts

What package is effected by this issue?

@web3-onboard/core

Is this a build or a runtime issue?

Runtime

Package Version

2.17.0

Node Version

16.17.1

What browsers are you seeing the problem on?

Chrome

Relevant log output

See screen.

Anything else?

web3-onboard/core@2.17.0 as dependency of web3-onboard/react@2.7.0

Sanity Check

• If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

[sirpy]

also currently in onboard demo https://reactdemo.blocknative.com/
it doesnt request multiple chains when connecting with wc2, so it is not possible to test switch chains there.

[Adamj1232]

@L03TJ3 thanks for raising this issue! Has goodDollar wallet fully implemented walletConnect v2 support? Has this been tested with a wallet outside of GoodDollar like Trust?
@sirpy we do not have plans for requesting multiple chains within the connect flow. We would expect the dapp or wallet to control this. Can you explain why would this functionality be needed?

[sirpy]

@Adamj1232
This issue also exists with walletconnect v2 example wallet
The G$ wallet works with walletconnect v2 example dapp

[sirpy]

@Adamj1232
This functionality is already supported in onboard with the "requiredChains" field
This functionality seems to be required since in v2 the wallet responds back with the list of supported chains.
This functionality seems to be ATLEAST preventing the ability to test the switch chain functionality between
https://reactdemo.blocknative.com/ sample dapp and wc2 sample wallet https://react-web3wallet.vercel.app/walletconnect

[L03TJ3]

Also added:
The wallet-not defined is an issue specifically when trying to switch
I can send transactions from the original connected chain, so the wallet not defined seems weird here

[Adamj1232]

@L03TJ3 PR to fix this issue: #1682

[Adamj1232]

@L03TJ3 @sirpy please give @web3-onboard/walletconnect v2.3.7-alpha.2 a go as it should close this issue

[L03TJ3]

@Adamj1232 Will test later today, thanks!