[Bug]: Scroll lock property is not removed when modal closes

[usame-algan]

Current Behavior

After closing the Wallet selection modal, the html element still has an inline style for overflow. This is causing issues with other Modals that set the scroll lock on a different element e.g. body.

Related issue: safe-global/safe-wallet-monorepo#744

Expected Behavior

After closing the modal, the overflow property on the html element should be removed to get back to the initial state.

Steps To Reproduce

Open and close the wallet selection modal and observe that the html element still has the overflow style attached to it.

What package is effected by this issue?

@web3-onboard/core

Is this a build or a runtime issue?

Runtime

Package Version

2.8.5

Node Version

16.14.12

What browsers are you seeing the problem on?

Firefox, Chrome

Relevant log output

No response

Anything else?

No response

Sanity Check

• If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

[lnbc1QWFyb24]

Thanks for creating this issue and associated fix with the PR. We will take a look at them both soon.

[Adamj1232]

@usame-algan I have tested your PR and it is working as expected. I will pull the branch down and add the necessary version changes 🤓 Thanks again!

[Adamj1232]

This fix is available with the latest alpha versions of the core/react/vue packages - thanks again!