[Feature]: Make account center request wallet permission if it's not the currently active one

[ihorbond]

Is your request related to a problem?

This request is inspired by #1219

Feature Description

Account Center widget shows the history of connected metamask wallets even though some of them could have been disconnected already by the user in the metamask directly and since there is no 'wallet disconnected' event we just don't know when this happens. Here's an example

As you can see I only have ...a42d wallet connected in metamask and have since disconnected ihor.eth yet I can select it in the Account Center.
I propose that whenever the metamask wallet is selected in the account center we send the wallet_getPermissions request first and look inside the caveats array.

If the wallet is not there anymore we send the wallet_requestPermissions request so that the user can select that wallet again and make it active. We can also "clean up" other wallet addresses that are still lingering in the Account Center at this time.

Alternative Solutions

Not that I'm aware of, I've looked all over Metamask docs.

Anything else?

We could also send the wallet_requestPermissions request whenever someone

1. clicks on Add Account
   
2. clicks "Connect another wallet" and selects Metamask from the modal window
   
   

[ihorbond]

Actually looks like just "wallet_getPermissions" won't cut it because even though we technically have permissions for 2 connected metamask accounts we can only send a transaction from the currently active one (right?)

So here's what I ended up doing whenever connectedWallet changes

const walletProvider = computed(
	() => new ethers.providers.Web3Provider(connectedWallet.value?.provider, 'any')
)

watch(connectedWallet, async (newVal, oldVal) => {

	// connected wallet emits twice hence this check
        const isRedundant = newVal?.label === oldVal?.label && JSON.stringify(newVal?.accounts) === JSON.stringify(oldVal?.accounts)
	if(isRedundant) return

	const { label, accounts } = newVal
	
	if(label === 'MetaMask') {
		
		const [{ address: primaryWallet }] = accounts
		const [activeWallet] = await walletProvider.value.listAccounts()

		console.log({
			primaryWallet,
			activeWallet
		})

		const normalizedPrimaryWallet = ethers.utils.getAddress(primaryWallet)
		const noramlizedActiveWallet = ethers.utils.getAddress(activeWallet)

		const permissions = await walletProvider.value.send('wallet_getPermissions')
		const { value: connectedMMWallets } = permissions[0].caveats.find(x => x.type === 'restrictReturnedAccounts')

		const isConnectedInMM = connectedMMWallets
			.map(a => ethers.utils.getAddress(a))
			.find(a => a === normalizedPrimaryWallet) !== undefined

		const isActive = normalizedPrimaryWallet === noramlizedActiveWallet

		const shouldRequest = !isConnectedInMM || !isActive 
		
		if(shouldRequest) {
			await walletProvider.value.send('wallet_requestPermissions', [{ eth_accounts: {} }])
		}
	}
})

This will "fix" the situation when Account Center still shows (and user selects) a wallet that has since been disconnected but won't fix the situation when the wallet selected in Account Center is already connected in MetaMask and is just not currently active

[ihorbond]

Would it be possible to expose this action ? This way we could subscribe to 'accountCenter' and filter out the accounts[] to remove the ones that aren't connected in metamask anymore whenever widget is expanded.
Would really love your feedback @taylorjdawson @aaronbarnardsound

[lnbc1QWFyb24]

@ihorbond thanks for these suggestions.

Actually looks like just "wallet_getPermissions" won't cut it because even though we technically have permissions for 2 connected metamask accounts we can only send a transaction from the currently active one (right?)

I believe as long as the user has granted permission to an account, then you can send a transaction from that account (even if it is not the currently "active" one) by just setting the from in the transaction object.

So I think we could just check permissions when an account is selected within account center to ensure that the account permissions are still granted, and if not, then re-request them. I think only MM has the permissions rpc calls at this point, so this will not help fix other wallets.

It would be great if MM would just return an array of all accounts that are connected in the accountsChanged event rather than just the first one :(

[lnbc1QWFyb24]

Hey @ihorbond can try installing core version: 2.9.0-alpha.1 and see if that works as you would expect?

[lnbc1QWFyb24]

Released in v2.13.0