Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 24, 2025


PR-Codex overview

This PR updates the API_URL constant in the route.ts file to use a secure HTTPS URL instead of a local HTTP URL, enhancing the security of API calls.

Detailed summary

  • Changed the API_URL from "http://localhost:3030" to https://${process.env.NEXT_PUBLIC_API_URL || "api.thirdweb.com"}.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Updated payment API connection to use production-appropriate endpoints instead of local development settings.

@vercel vercel bot temporarily deployed to Preview – nebula October 24, 2025 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 24, 2025 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 24, 2025 18:37 Inactive
@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb_playground Ready Ready Preview Comment Oct 24, 2025 6:41pm
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Oct 24, 2025 6:41pm
nebula Skipped Skipped Oct 24, 2025 6:41pm
thirdweb-www Skipped Skipped Oct 24, 2025 6:41pm
wallet-ui Skipped Skipped Oct 24, 2025 6:41pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 24, 2025 18:37 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

⚠️ No Changeset found

Latest commit: ffb032a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Playground Changes involving the Playground codebase. label Oct 24, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review October 24, 2025 18:37
@joaquim-verges joaquim-verges requested review from a team as code owners October 24, 2025 18:37
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The API endpoint configuration in the paywall route has been updated from a hardcoded localhost HTTP URL to a dynamic HTTPS URL that reads from an environment variable, defaulting to the production API domain.

Changes

Cohort / File(s) Change Summary
Paywall API Configuration
apps/playground-web/src/app/api/paywall/route.ts
Replaced hardcoded API URL http://localhost:3030 with a dynamic HTTPS URL using NEXT_PUBLIC_API_URL environment variable, defaulting to api.thirdweb.com

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch _Playground_Use_production_API_URL_instead_of_localhost

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3e9eb49 and ffb032a.

📒 Files selected for processing (1)
  • apps/playground-web/src/app/api/paywall/route.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@joaquim-verges joaquim-verges changed the title [Playground] Use production API URL instead of localhost [Playground] Use production API URL Oct 24, 2025
@joaquim-verges joaquim-verges merged commit 46b9d2d into main Oct 24, 2025
20 of 22 checks passed
@joaquim-verges joaquim-verges deleted the _Playground_Use_production_API_URL_instead_of_localhost branch October 24, 2025 18:38
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.90%. Comparing base (d5d5939) to head (ffb032a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8307      +/-   ##
==========================================
+ Coverage   54.87%   54.90%   +0.02%     
==========================================
  Files         919      919              
  Lines       60707    60675      -32     
  Branches     4127     4126       -1     
==========================================
  Hits        33315    33315              
+ Misses      27290    27259      -31     
+ Partials      102      101       -1     
Flag Coverage Δ
packages 54.90% <ø> (+0.02%) ⬆️
see 8 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.55 KB (0%) 1.3 s (0%) 220 ms (+96.54% 🔺) 1.6 s
thirdweb (cjs) 365.82 KB (0%) 7.4 s (0%) 1.1 s (+1.22% 🔺) 8.4 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 64 ms (+1258.91% 🔺) 178 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 43 ms (+891.65% 🔺) 53 ms
thirdweb/react (minimal + tree-shaking) 19.09 KB (0%) 382 ms (0%) 88 ms (+1075.9% 🔺) 470 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants