Skip to content

Conversation

@alecananian
Copy link
Contributor

@alecananian alecananian commented Oct 24, 2025

Moves @storybook/react package to be a dev dependency of the main thirdweb package. There shouldn't be a need to package this specific version of Storybook and ship it to SDK consumers since this is a development tool.

This fixes issues in pnpm workspaces consuming the thirdweb SDK where different workspaces are forced to use different versions of the SDK because of differing vite versions (a sub-dependency of @storybook/react)


PR-Codex overview

This PR focuses on moving the @storybook/react package from dependencies to devDependencies in the package.json file. It also includes updates to various package versions in the lock files, ensuring compatibility and optimization.

Detailed summary

  • Moved @storybook/react to devDependencies in packages/thirdweb/package.json.
  • Updated package version references in pnpm-lock.yaml for various dependencies.
  • Cleaned up redundant package version details across multiple entries in the lock files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Added a changeset entry marking a patch release.
    • Optimized package dependencies to reduce production bundle size by moving development-only tools to development dependencies.

@alecananian alecananian requested review from a team as code owners October 24, 2025 16:00
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: e20970d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch
wagmi-inapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2025

@alecananian is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Oct 24, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A changeset entry documents a patch release. The @storybook/react package is moved from runtime dependencies to devDependencies in the packages/thirdweb package.

Changes

Cohort / File(s) Summary
Changeset Documentation
\.changeset/rich-cities-sniff.md
New patch release changelog entry documenting the dependency change for @storybook/react.
Package Configuration
packages/thirdweb/package.json
Relocated @storybook/react version 9.0.15 from dependencies to devDependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • joaquim-verges

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[SDK] Fix: move @storybook/react package to be a dev dependency" accurately reflects the main change in the pull request. It follows the recommended format from the repository template, is concise and clear, and directly describes the primary action being taken. The title clearly communicates that this is a fix affecting the SDK and specifically addresses moving a package to devDependencies, making it easy for reviewers scanning the history to understand the core change at a glance.
Description Check ✅ Passed The PR description provides meaningful context for the change, explaining that @storybook/react is a development tool and should not be shipped to SDK consumers, and it clearly articulates the rationale for the fix: resolving pnpm workspace issues caused by conflicting vite versions. While the description does not explicitly include the "Notes for the reviewer" and "How to test" sections suggested in the template, it does cover the essential information needed to understand the change's purpose and scope. The description is specific and substantive rather than vague or generic, providing sufficient detail for reviewers to evaluate the PR.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d1fa243 and e20970d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • packages/thirdweb/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joaquim-verges
Copy link
Member

good catch! ty @alecananian

@jnsdls jnsdls merged commit 759b93b into thirdweb-dev:main Oct 29, 2025
3 of 9 checks passed
@joaquim-verges joaquim-verges mentioned this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants