-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Fix: move @storybook/react package to be a dev dependency
#8306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix: move @storybook/react package to be a dev dependency
#8306
Conversation
🦋 Changeset detectedLatest commit: e20970d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@alecananian is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
Caution Review failedThe pull request is closed. WalkthroughA changeset entry documents a patch release. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
good catch! ty @alecananian |
Moves
@storybook/reactpackage to be a dev dependency of the mainthirdwebpackage. There shouldn't be a need to package this specific version of Storybook and ship it to SDK consumers since this is a development tool.This fixes issues in
pnpmworkspaces consuming thethirdwebSDK where different workspaces are forced to use different versions of the SDK because of differingviteversions (a sub-dependency of@storybook/react)PR-Codex overview
This PR focuses on moving the
@storybook/reactpackage from dependencies to devDependencies in thepackage.jsonfile. It also includes updates to various package versions in the lock files, ensuring compatibility and optimization.Detailed summary
@storybook/reactto devDependencies inpackages/thirdweb/package.json.pnpm-lock.yamlfor various dependencies.Summary by CodeRabbit