Update factory #8301
Update factory #8301
Conversation
🦋 Changeset detectedLatest commit: d5d5939 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughAdds a changeset documenting a patch release and inserts a chain-specific Create2 factory address for Neura testnet (chain ID 267) into the factories lookup. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts (1)
324-324: Use the COMMON_FACTORY_ADDRESS constant for chain 267 to improve consistency.Line 324 duplicates the factory address as a hardcoded literal, while lines 325-326 reference
COMMON_FACTORY_ADDRESSdirectly. Since the hardcoded value at line 324 (0x4e59b44847b379578588920cA78FbF26c0B4956C) matches the constant definition exactly (line 20), refactoring to use the constant improves consistency and prevents future divergence:const FACTORIES: Record<string, string> = { "88888": "0xc501b9abf5540de1dd24f66633b1ecf35ff7101f", - "267": "0x4e59b44847b379578588920cA78FbF26c0B4956C", + "267": COMMON_FACTORY_ADDRESS, "420120000": COMMON_FACTORY_ADDRESS, "420120001": COMMON_FACTORY_ADDRESS, };Note: On-chain verification that the factory is deployed at this address on chain 267 is outside code review scope and should be confirmed by deployment validation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.changeset/weak-guests-fry.md(1 hunks)packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
.changeset/*.md: Each change inpackages/*must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API
Files:
.changeset/weak-guests-fry.md
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts
packages/thirdweb/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
packages/thirdweb/**/*.{ts,tsx}: Every public symbol must have comprehensive TSDoc with at least one compiling@exampleand a custom tag (@beta,@internal,@experimental, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Lazy‑load heavy dependencies inside async paths (e.g.,const { jsPDF } = await import("jspdf"))
Files:
packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts
🪛 LanguageTool
.changeset/weak-guests-fry.md
[grammar] ~4-~4: Ensure spelling is correct
Context: --- "thirdweb": patch --- create2 factory for neura testnet
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
.changeset/weak-guests-fry.md (1)
1-5: LGTM!The changeset format is correct and follows the guidelines. The "patch" version bump is appropriate for this infrastructure change. The static analysis hint about "neura" is a false positive—it's the proper name of the testnet.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8301 +/- ##
=======================================
Coverage 54.86% 54.87%
=======================================
Files 919 919
Lines 60706 60707 +1
Branches 4126 4127 +1
=======================================
+ Hits 33309 33315 +6
+ Misses 27295 27290 -5
Partials 102 102
🚀 New features to boost your workflow:
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a patch for the `thirdweb` package, adding a new factory address for the `create2` deployment on the Neura testnet.
### Detailed summary
- Added a new factory address for `267`: `0x4e59b44847b379578588920cA78FbF26c0B4956C` to the `FACTORIES` record in `create-2-factory.ts`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **New Features**
* Added support for Neura testnet in Create2 factory deployments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
yash/create2-factory-neura-testnet
branch
from
9070eef to
d5d5939
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/weak-guests-fry.md (1)
5-5: Capitalize "Create2" and "Neura" in the description.The changeset description uses lowercase "create2" and "neura", which should follow standard capitalization conventions. "Create2" is the standard naming for the EVM opcode/factory, and the PR description uses "Neura testnet" (capital N).
Apply this diff to improve consistency with conventions:
-create2 factory for neura testnet +Create2 factory for Neura testnet
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.changeset/weak-guests-fry.md(1 hunks)packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
.changeset/*.md: Each change inpackages/*must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API
Files:
.changeset/weak-guests-fry.md
🪛 LanguageTool
.changeset/weak-guests-fry.md
[grammar] ~4-~4: Ensure spelling is correct
Context: --- "thirdweb": patch --- create2 factory for neura testnet
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
.changeset/weak-guests-fry.md (1)
1-5: Changeset structure and versioning are correct.The changeset file is properly formatted with the correct package name ("thirdweb") and version bump type (patch). Adding a new chain-specific factory address is a non-API change, so the patch bump is appropriate.
2 participants
PR-Codex overview
This PR introduces a patch for the
thirdwebpackage, specifically updating thecreate-2-factory.tsfile to include a new factory address for a specific network.Detailed summary
0x4e59b44847b379578588920cA78FbF26c0B4956Cfor the network identifier267in theFACTORIESrecord withincreate-2-factory.ts.Summary by CodeRabbit