Skip to content

Conversation

@alecananian
Copy link
Contributor

@alecananian alecananian commented Oct 22, 2025

Updates the inputMode prop on the React Native's Send Funds screen amount input to show a keyboard with a decimal place, so amounts with decimals can be sent.

Before After

PR-Codex overview

This PR focuses on fixing the Send Funds screen in the thirdweb React Native application to allow users to input decimal amounts.

Detailed summary

  • Updated the inputMode property of the ThemedInput component in SendScreen.tsx from "numeric" to "decimal" to support decimal input.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes
    • Send Funds screen now accepts decimal amounts for transaction inputs, enabling more precise fund transfer amounts.

@alecananian alecananian requested review from a team as code owners October 22, 2025 22:12
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2025

🦋 Changeset detected

Latest commit: e32f10f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 22, 2025

@alecananian is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Oct 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Walkthrough

A changeset is added documenting a React Native fix for the Send Funds screen. The amount input field's keyboard mode is changed from "numeric" to "decimal" to enable decimal amount input.

Changes

Cohort / File(s) Change Summary
Changeset documentation
\.changeset/clear-seals-kneel.md
New patch changeset file documenting React Native Send Funds screen fix for decimal amount support.
React Native UI input mode
packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx
Changed amount input field inputMode property from "numeric" to "decimal" to allow decimal input.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description does not use the repository’s standard template and is missing the required “## Notes for the reviewer” and “## How to test” sections as well as any issue tag header. Please update the description to include the standard template comment, add a “## Notes for the reviewer” section with any important context, and include a “## How to test” section outlining verification steps.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title follows the repository prefix convention, is concise, and clearly summarizes the core change to enable decimal input in the Send Funds screen.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c36cfbb and e32f10f.

📒 Files selected for processing (2)
  • .changeset/clear-seals-kneel.md (1 hunks)
  • packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from @/types where applicable
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size

Files:

  • packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

  • packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx
packages/thirdweb/**/*.{ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

packages/thirdweb/**/*.{ts,tsx}: Every public symbol must have comprehensive TSDoc with at least one compiling @example and a custom tag (@beta, @internal, @experimental, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Lazy‑load heavy dependencies inside async paths (e.g., const { jsPDF } = await import("jspdf"))

Files:

  • packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx
.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

.changeset/*.md: Each change in packages/* must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API

Files:

  • .changeset/clear-seals-kneel.md
🔇 Additional comments (1)
packages/thirdweb/src/react/native/ui/connect/SendScreen.tsx (1)

186-186: Decimal input support confirmed

Switching the amount field to inputMode="decimal" ensures the OS surfaces a keypad with a decimal separator, matching the React Native TextInput guidance for decimal-friendly input. (reactnative.dev)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof thank you for this! the react native components needs some love

@joaquim-verges joaquim-verges merged commit 85fe949 into thirdweb-dev:main Oct 22, 2025
4 of 9 checks passed
@joaquim-verges joaquim-verges mentioned this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants