[MNY-275] Surface the error from bridge API in SwapWidget UI #8277

MananTank · 2025-10-17T18:32:09Z

PR-Codex overview

This PR enhances error handling in the swap-ui.tsx component by providing a more informative error message when fetching quote details fails.

Detailed summary

Added the multiline prop to the component.
Updated the error message for preparedResultQuery.error to display preparedResultQuery.error.message if available, defaulting to "Failed to get a quote".
Retained existing error messages for buyTokenQuery and sellTokenQuery.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Improved error display in the swap widget: error text now shows a more specific message when available, falls back to a generic "Failed to get a quote" message otherwise, and supports multiline wrapping so longer errors are fully visible.

vercel · 2025-10-17T18:32:12Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
docs-v2	Ready	Preview	Comment	Oct 18, 2025 0:13am
nebula	Ready	Preview	Comment	Oct 18, 2025 0:13am
thirdweb_playground	Ready	Preview	Comment	Oct 18, 2025 0:13am
thirdweb-www	Ready	Preview	Comment	Oct 18, 2025 0:13am
wallet-ui	Ready	Preview	Comment	Oct 18, 2025 0:13am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

linear · 2025-10-17T18:32:12Z

MNY-275 show error message when fetching quote in SwapWidget

changeset-bot · 2025-10-17T18:32:15Z

⚠️ No Changeset found

Latest commit: ca16ec7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MananTank · 2025-10-17T18:32:24Z

[MNY-275] Surface the error from bridge API in SwapWidget UI #8277 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2025-10-17T18:32:36Z

Walkthrough

Error rendering in the Swap widget now displays the API error message when available (using preparedResultQuery.error.message), falling back to "Failed to get a quote". The error Text component now has multiline enabled to allow wrapping.

Changes

Cohort / File(s)	Summary
SwapWidget error handling `packages/thirdweb/src/react/web/ui/Bridge/swap-widget/swap-ui.tsx`	Use `preparedResultQuery.error.message` if present, otherwise fallback to `"Failed to get a quote"`. Add `multiline` prop to the `Text` component to allow error text wrapping.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description lacks proper completion of the template sections. While the description includes a helpful PR-Codex auto-generated overview that explains the changes (error message updates and multiline prop addition), the template-required sections like "Notes for the reviewer" and "How to test" are not meaningfully filled out—they remain as template comments rather than author-provided guidance. The PR would benefit from explicit reviewer notes and testing instructions to facilitate the review process.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "[MNY-275] Surface the error from bridge API in SwapWidget UI" is clear, specific, and directly aligned with the actual changes made. It includes the issue tag and describes the primary change—improving error handling by displaying API error messages in the SwapWidget UI. The title accurately reflects the main objective without vague language.
Linked Issues Check	✅ Passed	The pull request directly addresses the objective stated in MNY-275: "Surface the error returned by the quote/bridge API in the SwapWidget UI." The changes implement this by updating the error message rendering to display preparedResultQuery.error.message when available, with a fallback to "Failed to get a quote." The addition of the multiline prop ensures proper formatting of these error messages. The implementation aligns precisely with the requirement to surface API errors to users.
Out of Scope Changes Check	✅ Passed
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch mny-275

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dad67b8 and ca16ec7.

📒 Files selected for processing (1)

packages/thirdweb/src/react/web/ui/Bridge/swap-widget/swap-ui.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/thirdweb/src/react/web/ui/Bridge/swap-widget/swap-ui.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Size
GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-10-17T18:37:37Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	64.51 KB (0%)	1.3 s (0%)	147 ms (+178.95% 🔺)	1.5 s
thirdweb (cjs)	365.68 KB (0%)	7.4 s (0%)	533 ms (+8.68% 🔺)	7.9 s
thirdweb (minimal + tree-shaking)	5.73 KB (0%)	115 ms (0%)	68 ms (+2249.54% 🔺)	182 ms
thirdweb/chains (tree-shaking)	526 B (0%)	11 ms (0%)	40 ms (+1139.22% 🔺)	51 ms
thirdweb/react (minimal + tree-shaking)	19.13 KB (0%)	383 ms (0%)	54 ms (+1266.84% 🔺)	437 ms

codecov · 2025-10-18T00:03:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.90%. Comparing base (b1a7808) to head (ca16ec7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8277   +/-   ##
=======================================
  Coverage   54.89%   54.90%           
=======================================
  Files         919      919           
  Lines       60622    60622           
  Branches     4126     4116   -10     
=======================================
+ Hits        33278    33282    +4     
+ Misses      27242    27239    -3     
+ Partials      102      101    -1

Flag	Coverage Δ
packages	`54.90% <ø> (+<0.01%)`	⬆️
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graphite-app · 2025-10-18T00:05:06Z

Merge activity

Oct 18, 12:05 AM UTC: MananTank added this pull request to the Graphite merge queue.
Oct 18, 12:14 AM UTC: Merged by the Graphite merge queue.

--- ## PR-Codex overview This PR focuses on improving error handling in the `swap-ui.tsx` component by providing more detailed error messages when fetching data fails. ### Detailed summary - Added `multiline` property to a component. - Updated error message for `preparedResultQuery.error` to display the specific error message if available, falling back to "Failed to get a quote". - Retained existing error messages for `buyTokenQuery` and `sellTokenQuery`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit * **Bug Fixes** * Improved error display in the swap widget: error text now shows a more specific message when available, falls back to a generic failure message otherwise, and supports multiline wrapping so longer errors are fully visible to users.

MananTank marked this pull request as ready for review October 17, 2025 18:32

MananTank requested review from a team as code owners October 17, 2025 18:32

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Oct 17, 2025

github-actions bot assigned MananTank Oct 17, 2025

MananTank marked this pull request as draft October 17, 2025 18:33

vercel bot deployed to Preview – nebula October 17, 2025 18:35 View deployment

vercel bot deployed to Preview – thirdweb-www October 17, 2025 18:40 View deployment

vercel bot deployed to Preview – wallet-ui October 17, 2025 18:43 View deployment

vercel bot deployed to Preview – thirdweb_playground October 17, 2025 18:47 View deployment

vercel bot deployed to Preview – docs-v2 October 17, 2025 19:00 View deployment

joaquim-verges approved these changes Oct 17, 2025

View reviewed changes

MananTank marked this pull request as ready for review October 17, 2025 20:56

MananTank force-pushed the mny-275 branch from 2763335 to dad67b8 Compare October 17, 2025 22:29

vercel bot deployed to Preview – nebula October 17, 2025 22:31 View deployment

vercel bot deployed to Preview – wallet-ui October 17, 2025 22:35 View deployment

vercel bot deployed to Preview – thirdweb-www October 17, 2025 22:36 View deployment

vercel bot deployed to Preview – docs-v2 October 17, 2025 22:37 View deployment

vercel bot deployed to Preview – thirdweb_playground October 17, 2025 22:38 View deployment

graphite-app bot force-pushed the mny-275 branch from dad67b8 to ca16ec7 Compare October 18, 2025 00:05

vercel bot deployed to Preview – thirdweb_playground October 18, 2025 00:06 View deployment

vercel bot deployed to Preview – wallet-ui October 18, 2025 00:07 View deployment

vercel bot deployed to Preview – nebula October 18, 2025 00:07 View deployment

vercel bot deployed to Preview – docs-v2 October 18, 2025 00:09 View deployment

vercel bot deployed to Preview – thirdweb-www October 18, 2025 00:13 View deployment

graphite-app bot merged commit ca16ec7 into main Oct 18, 2025
24 checks passed

graphite-app bot deleted the mny-275 branch October 18, 2025 00:14

vercel bot deployed to Production – nebula October 18, 2025 00:17 View deployment

vercel bot deployed to Production – thirdweb_playground October 18, 2025 00:19 View deployment

vercel bot deployed to Production – wallet-ui October 18, 2025 00:20 View deployment

vercel bot deployed to Production – thirdweb-www October 18, 2025 00:23 View deployment

vercel bot deployed to Production – docs-v2 October 18, 2025 00:31 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MNY-275] Surface the error from bridge API in SwapWidget UI #8277

[MNY-275] Surface the error from bridge API in SwapWidget UI #8277

Uh oh!

MananTank commented Oct 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

linear bot commented Oct 17, 2025

Uh oh!

changeset-bot bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

MananTank commented Oct 17, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 17, 2025 •

edited

Loading

Review ran into problems

Uh oh!

github-actions bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 18, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[MNY-275] Surface the error from bridge API in SwapWidget UI #8277

[MNY-275] Surface the error from bridge API in SwapWidget UI #8277

Uh oh!

Conversation

MananTank commented Oct 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Oct 17, 2025

Uh oh!

changeset-bot bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

MananTank commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Review ran into problems

Uh oh!

github-actions bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Oct 17, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Oct 17, 2025 •

edited

Loading

changeset-bot bot commented Oct 17, 2025 •

edited

Loading

MananTank commented Oct 17, 2025 •

edited

Loading

coderabbitai bot commented Oct 17, 2025 •

edited

Loading

github-actions bot commented Oct 17, 2025 •

edited

Loading

codecov bot commented Oct 18, 2025 •

edited

Loading

graphite-app bot commented Oct 18, 2025 •

edited

Loading