[PRO-48] Dashboard: Bridge page UI updates #8274
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
WalkthroughRenamed an analytics event linkType option to "bridge-docs"; removed the PillLink component; renamed and restructured FAQ/header components, added client-only theme-toggle and docs controls in headers, and reorganized the bridge page layout and imports. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Header as Bridge/Tokens Header
participant Analytics as reportBridgePageLinkClick
Note over Header,Analytics: Header adds docs & trending controls + theme toggle (client-only)
User->>Header: Click "Documentation" or "Trending Tokens"
Header->>Analytics: reportBridgePageLinkClick({ linkType: "bridge-docs" | "trending-tokens" })
Header-->>User: Open external docs / navigate
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8274 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 919 919
Lines 60622 60622
Branches 4126 4126
=======================================
Hits 33278 33278
Misses 27242 27242
Partials 102 102
🚀 New features to boost your workflow:
|
size-limit report 📦
|
graphite-app
bot
changed the base branch from
10-17-dashboard_fix_autoconnect_in__bridge_page
to
graphite-base/8274
graphite-app
bot
force-pushed
the
graphite-base/8274
branch
from
a90569d to
12082fd
Compare
graphite-app
bot
force-pushed
the
pro-48
branch
from
094109b to
fcc4052
Compare
graphite-app
bot
force-pushed
the
pro-48
branch
from
fcc4052 to
3fd2285
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
apps/dashboard/src/@/components/blocks/faq-section.tsx (1)
30-30: Fix typo in variable name.The setter is named
setIsOpennwith an extra 'n'. This should besetIsOpenfor consistency and readability.Apply this diff:
- const [isOpen, setIsOpenn] = useState(false); + const [isOpen, setIsOpen] = useState(false); const contentId = useId(); return ( <DynamicHeight> <div className={cn("border-b border-dashed", props.className)}> <h3> <Button variant="ghost" - onClick={() => setIsOpenn(!isOpen)} + onClick={() => setIsOpen(!isOpen)}apps/dashboard/src/app/bridge/page.tsx (1)
117-132: Avoid duplication: reuse the shared DotsBackgroundPattern.This inline implementation duplicates
DotsBackgroundPatternfrom@/components/ui/background-patterns.tsx(lines 3-18) with different styling (inset values, opacity, visibility constraints). Per coding guidelines, prefer composition and avoid duplication.Apply this diff to use the shared component:
+import { DotsBackgroundPattern } from "@/components/ui/background-patterns";Replace the inline implementation:
-function DotsBackgroundPattern(props: { className?: string }) { - return ( - <div - className={cn( - "pointer-events-none absolute -inset-x-36 -inset-y-24 text-foreground/20 dark:text-muted-foreground/20 hidden lg:block", - props.className, - )} - style={{ - backgroundImage: "radial-gradient(currentColor 1px, transparent 1px)", - backgroundSize: "24px 24px", - maskImage: - "radial-gradient(ellipse 100% 100% at 50% 50%, black 30%, transparent 50%)", - }} - /> - ); -}At line 59, pass the custom styling via className:
- <DotsBackgroundPattern /> + <DotsBackgroundPattern className="-inset-x-36 -inset-y-24 text-foreground/20 dark:text-muted-foreground/20 hidden lg:block" />If this styling is a common pattern, consider adding it to the shared component as a variant prop.
🧹 Nitpick comments (1)
apps/dashboard/src/app/bridge/page.tsx (1)
109-115: Consider exposing className prop for flexibility.Per coding guidelines for dashboard apps, components should expose a
classNameprop on the root element. While DataPill has fixed styling now, adding className support improves reusability.Apply this diff:
-function DataPill(props: { children: React.ReactNode }) { +function DataPill(props: { children: React.ReactNode; className?: string }) { return ( <p className={cn( - "bg-card flex items-center text-xs lg:text-sm gap-1.5 text-foreground border rounded-full px-8 lg:px-3 py-1.5 hover:text-foreground transition-colors duration-300" + "bg-card flex items-center text-xs lg:text-sm gap-1.5 text-foreground border rounded-full px-8 lg:px-3 py-1.5 hover:text-foreground transition-colors duration-300", + props.className, )}>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
apps/dashboard/src/@/analytics/report.ts(1 hunks)apps/dashboard/src/@/components/blocks/faq-section.tsx(1 hunks)apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsx(2 hunks)apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx(3 hunks)apps/dashboard/src/app/bridge/components/client/pill-link.tsx(0 hunks)apps/dashboard/src/app/bridge/components/header.tsx(2 hunks)apps/dashboard/src/app/bridge/page.tsx(3 hunks)
💤 Files with no reviewable changes (1)
- apps/dashboard/src/app/bridge/components/client/pill-link.tsx
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/page.tsxapps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/page.tsxapps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/page.tsxapps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/_(e.g., Button, Input, Tabs, Card)
UseNavLinkfor internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names withcn()from@/lib/utilsfor conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start withimport "server-only"; usenext/headers, server‑only env, heavy data fetching, andredirect()where appropriate
Client Components must start with'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: callgetAuthToken()from cookies, sendAuthorization: Bearer <token>header, and return typed results (avoidany)
Client-side data fetching: wrap calls in React Query with descriptive, stablequeryKeysand set sensiblestaleTime/cacheTime(≥ 60s default); keep tokens secret via internal routes or server actions
Do not importposthog-jsin server components (client-side only)
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/page.tsxapps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
apps/{dashboard,playground}/**/*.tsx
📄 CodeRabbit inference engine (AGENTS.md)
Expose a
classNameprop on the root element of every component
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/page.tsxapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
apps/{dashboard,playground}/src/@/analytics/report.ts
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/src/@/analytics/report.ts: Checkreport.tsbefore adding a new analytics event to avoid duplicates
Analytics naming: event name as<subject> <verb>; helper function asreport<Subject><Verb>(PascalCase)
Each analytics helper must include a JSDoc header (Why/Owner), accept a single typedpropertiesobject, and forward it unchanged toposthog.capture
Files:
apps/dashboard/src/@/analytics/report.ts
🧠 Learnings (4)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to apps/{dashboard,playground}/src/@/analytics/report.ts : Analytics naming: event name as `<subject> <verb>`; helper function as `report<Subject><Verb>` (PascalCase)
Applied to files:
apps/dashboard/src/@/analytics/report.ts
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to src/@/analytics/report.ts : Review `src/@/analytics/report.ts` before adding analytics events to check for duplicates
Applied to files:
apps/dashboard/src/@/analytics/report.ts
📚 Learning: 2025-07-31T16:17:42.753Z
Learnt from: MananTank
PR: thirdweb-dev/js#7768
File: apps/playground-web/src/app/navLinks.ts:1-1
Timestamp: 2025-07-31T16:17:42.753Z
Learning: Configuration files that import and reference React components (like icon components from lucide-react) need the "use client" directive, even if they primarily export static data, because the referenced components need to be executed in a client context when used by other client components.
Applied to files:
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Use the `container` class with a `max-w-7xl` cap for page width consistency.
Applied to files:
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
🧬 Code graph analysis (4)
apps/dashboard/src/app/bridge/page.tsx (4)
apps/dashboard/src/app/bridge/components/header.tsx (1)
BridgePageHeader(14-74)apps/dashboard/src/@/components/ui/background-patterns.tsx (1)
DotsBackgroundPattern(4-19)apps/dashboard/src/app/bridge/components/client/UniversalBridgeEmbed.tsx (1)
UniversalBridgeEmbed(19-40)apps/dashboard/src/@/components/blocks/faq-section.tsx (1)
FaqAccordion(8-23)
apps/dashboard/src/app/bridge/components/header.tsx (3)
apps/dashboard/src/@/analytics/report.ts (1)
reportBridgePageLinkClick(685-689)apps/dashboard/src/app/(app)/components/ThirdwebMiniLogo.tsx (1)
ThirdwebMiniLogo(7-90)apps/dashboard/src/@/components/blocks/color-mode-toggle.tsx (1)
ToggleThemeButton(10-36)
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsx (1)
apps/dashboard/src/@/components/blocks/faq-section.tsx (1)
FaqAccordion(8-23)
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx (2)
apps/dashboard/src/@/components/blocks/color-mode-toggle.tsx (1)
ToggleThemeButton(10-36)apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/_components/PublicPageConnectButton.tsx (1)
PublicPageConnectButton(13-43)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/dashboard/src/@/analytics/report.ts (1)
685-689: Verified: All call sites properly updated.The type change from
"integrate-bridge"to"bridge-docs"is complete and correct. All three call sites inapps/dashboard/src/app/bridge/components/header.tsx(lines 28, 42, and 55) have been updated to use valid parameter values ("bridge-docs"and"trending-tokens"). No orphaned code remains.apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsx (1)
76-87: LGTM: Clean separation of concerns.The new FaqSection wrapper provides the heading and delegates item rendering to FaqAccordion, following a clear composition pattern consistent with the refactoring across the PR.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx (1)
12-12: Add explicit return type.Per coding guidelines, functions should have explicit return types.
As per coding guidelines.
Apply this diff:
-export function PageHeader(props: { containerClassName?: string }) { +export function PageHeader(props: { containerClassName?: string }): JSX.Element {
♻️ Duplicate comments (2)
apps/dashboard/src/app/bridge/components/header.tsx (1)
70-96: Eliminate duplication: use the shared ToggleThemeButton.This local implementation duplicates the shared
ToggleThemeButtonat@/components/blocks/color-mode-toggle.tsx. The styling differences (ghost variant, icon size, skeleton size) can be handled via the shared component'sclassNameprop.Apply this diff to use the shared component:
-function ToggleThemeButton(props: { className?: string }) { - const { setTheme, theme } = useTheme(); - - return ( - <ClientOnly - ssr={<Skeleton className="size-[36px] rounded-full border bg-accent" />} - > - <Button - aria-label="Toggle theme" - className={cn( - "h-auto w-auto rounded-full p-2 text-muted-foreground hover:text-foreground", - props.className, - )} - onClick={() => { - setTheme(theme === "dark" ? "light" : "dark"); - }} - variant="ghost" - > - {theme === "light" ? ( - <SunIcon className="size-5 " /> - ) : ( - <MoonIcon className="size-5 " /> - )} - </Button> - </ClientOnly> - ); -}Update the imports:
-import { BookOpenIcon, CoinsIcon, MoonIcon, SunIcon } from "lucide-react"; +import { BookOpenIcon, CoinsIcon } from "lucide-react"; import Link from "next/link"; -import { useTheme } from "next-themes"; import { reportBridgePageLinkClick } from "@/analytics/report"; import { ClientOnly } from "@/components/blocks/client-only"; +import { ToggleThemeButton } from "@/components/blocks/color-mode-toggle"; import { Button } from "@/components/ui/button"; import { Skeleton } from "@/components/ui/skeleton";If the styling needs to differ from the shared component, pass a
classNameprop to override specific styles.apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx (1)
49-75: Eliminate duplication: reuse the shared ToggleThemeButton.This internal ToggleThemeButton duplicates the shared component at
@/components/blocks/color-mode-toggle.tsxwith only minor styling differences (ghost vs outline variant, skeleton size 36px vs 34px, icon size).Import and reuse the shared component:
-import { BookOpenIcon, MoonIcon, SunIcon } from "lucide-react"; +import { BookOpenIcon } from "lucide-react"; import Link from "next/link"; -import { useTheme } from "next-themes"; -import { ClientOnly } from "@/components/blocks/client-only"; -import { Button } from "@/components/ui/button"; -import { Skeleton } from "@/components/ui/skeleton"; +import { ToggleThemeButton } from "@/components/blocks/color-mode-toggle";Remove the local implementation:
- -function ToggleThemeButton(props: { className?: string }) { - const { setTheme, theme } = useTheme(); - - return ( - <ClientOnly - ssr={<Skeleton className="size-[36px] rounded-full border bg-accent" />} - > - <Button - aria-label="Toggle theme" - className={cn( - "h-auto w-auto rounded-full p-2 text-muted-foreground hover:text-foreground", - props.className, - )} - onClick={() => { - setTheme(theme === "dark" ? "light" : "dark"); - }} - variant="ghost" - > - {theme === "light" ? ( - <SunIcon className="size-5 " /> - ) : ( - <MoonIcon className="size-5 " /> - )} - </Button> - </ClientOnly> - ); -}If the ghost variant and larger sizing are preferred, update the shared component to accept variant/size props.
🧹 Nitpick comments (4)
apps/dashboard/src/app/bridge/components/header.tsx (2)
14-16: AddclassNameprop to the root element.Per coding guidelines, dashboard components should expose a
classNameprop on the root element. Currently, onlycontainerClassNameis exposed and applied to an inner element.Apply this diff:
-export function BridgePageHeader(props: { containerClassName?: string }) { +export function BridgePageHeader(props: { + className?: string; + containerClassName?: string; +}) { return ( - <div className="border-b border-border/70"> + <div className={cn("border-b border-border/70", props.className)}>As per coding guidelines
89-89: Remove trailing space in className.Minor formatting:
"size-5 "has a trailing space.Apply this diff:
- <SunIcon className="size-5 " /> + <SunIcon className="size-5" />apps/dashboard/src/@/components/blocks/faq-section.tsx (2)
30-30: Fix typo in state setter name.The state setter is named
setIsOpenn(extra 'n') instead ofsetIsOpen. While this doesn't affect functionality, it's a code quality issue.Apply this diff to fix the typo:
- const [isOpen, setIsOpenn] = useState(false); + const [isOpen, setIsOpen] = useState(false);variant="ghost" - onClick={() => setIsOpenn(!isOpen)} + onClick={() => setIsOpen(!isOpen)} aria-controls={contentId}
25-29: Add explicit return type per coding guidelines.The function declaration is missing an explicit return type, which is required by the TypeScript coding guidelines.
As per coding guidelines.
Apply this diff:
function FaqItem(props: { title: string; description: string; className?: string; -}) { +}): React.JSX.Element {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
apps/dashboard/src/@/analytics/report.ts(1 hunks)apps/dashboard/src/@/components/blocks/faq-section.tsx(1 hunks)apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsx(2 hunks)apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx(3 hunks)apps/dashboard/src/app/bridge/components/client/pill-link.tsx(0 hunks)apps/dashboard/src/app/bridge/components/header.tsx(2 hunks)apps/dashboard/src/app/bridge/page.tsx(3 hunks)
💤 Files with no reviewable changes (1)
- apps/dashboard/src/app/bridge/components/client/pill-link.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
- apps/dashboard/src/@/analytics/report.ts
- apps/dashboard/src/app/bridge/page.tsx
- apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsx
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/_(e.g., Button, Input, Tabs, Card)
UseNavLinkfor internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names withcn()from@/lib/utilsfor conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start withimport "server-only"; usenext/headers, server‑only env, heavy data fetching, andredirect()where appropriate
Client Components must start with'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: callgetAuthToken()from cookies, sendAuthorization: Bearer <token>header, and return typed results (avoidany)
Client-side data fetching: wrap calls in React Query with descriptive, stablequeryKeysand set sensiblestaleTime/cacheTime(≥ 60s default); keep tokens secret via internal routes or server actions
Do not importposthog-jsin server components (client-side only)
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
apps/{dashboard,playground}/**/*.tsx
📄 CodeRabbit inference engine (AGENTS.md)
Expose a
classNameprop on the root element of every component
Files:
apps/dashboard/src/@/components/blocks/faq-section.tsxapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
🧠 Learnings (4)
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Applied to files:
apps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Prefer composable primitives over custom markup: `Button`, `Input`, `Select`, `Tabs`, `Card`, `Sidebar`, `Separator`, `Badge`.
Applied to files:
apps/dashboard/src/app/bridge/components/header.tsx
📚 Learning: 2025-07-31T16:17:42.753Z
Learnt from: MananTank
PR: thirdweb-dev/js#7768
File: apps/playground-web/src/app/navLinks.ts:1-1
Timestamp: 2025-07-31T16:17:42.753Z
Learning: Configuration files that import and reference React components (like icon components from lucide-react) need the "use client" directive, even if they primarily export static data, because the referenced components need to be executed in a client context when used by other client components.
Applied to files:
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Use the `container` class with a `max-w-7xl` cap for page width consistency.
Applied to files:
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
🧬 Code graph analysis (2)
apps/dashboard/src/app/bridge/components/header.tsx (3)
apps/dashboard/src/app/(app)/components/ThirdwebMiniLogo.tsx (1)
ThirdwebMiniLogo(7-90)apps/dashboard/src/@/analytics/report.ts (1)
reportBridgePageLinkClick(685-689)apps/dashboard/src/@/components/blocks/color-mode-toggle.tsx (1)
ToggleThemeButton(10-36)
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx (2)
apps/dashboard/src/@/components/blocks/color-mode-toggle.tsx (1)
ToggleThemeButton(10-36)apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/_components/PublicPageConnectButton.tsx (1)
PublicPageConnectButton(13-43)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx (1)
1-11: LGTM: Client directive and imports are appropriate.The "use client" directive and imports are correctly configured for this interactive header component.
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring components related to FAQ sections, modifying link types for analytics, and enhancing the header components in the bridge application.
### Detailed summary
- Changed `linkType` in `reportBridgePageLinkClick` from `"integrate-bridge"` to `"bridge-docs"`.
- Renamed `FaqSection` to `FaqAccordion` and updated its implementation.
- Introduced a new `FaqSection` component wrapping `FaqAccordion`.
- Renamed `PageHeader` to `BridgePageHeader`.
- Updated `PillLink` references to use `FaqAccordion`.
- Enhanced styling and structure of header and FAQ sections.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **New Features**
* Theme toggle added to dashboard headers
* Documentation quick-access added to headers and bridge area
* **UI/Layout Changes**
* Redesigned bridge page with a new hero/heading and data pill layout
* FAQ section refactored into an accordion-style component
* Header navigation updated to include trending tokens and documentation controls
* Removed legacy pill-style external link component
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
pro-48
branch
from
7585dce to
9bb65ad
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/dashboard/src/app/bridge/page.tsx (1)
25-31: Fix searchParams typing, normalize array values, and guard chainId parsing.Next.js passes
searchParamsas a plain object, not a Promise. Also handlestring | string[]correctly and avoidNaNfromNumber(array).Apply:
-export default async function BridgePage({ - searchParams, -}: { - searchParams: Promise<Record<string, string | string[]>>; -}) { - const { chainId, tokenAddress, amount } = await searchParams; +export default async function BridgePage({ + searchParams, +}: { + searchParams: Record<string, string | string[] | undefined>; +}) { + const firstOf = (v?: string | string[]) => (Array.isArray(v) ? v[0] : v); + const chainIdStr = firstOf(searchParams.chainId); + const tokenAddressStr = firstOf(searchParams.tokenAddress); + const amountStr = firstOf(searchParams.amount); + const chainIdNum = + chainIdStr && !Number.isNaN(Number(chainIdStr)) ? Number(chainIdStr) : undefined; @@ - if (chainId && tokenAddress) { + if (chainIdNum && tokenAddressStr) { try { const metadata = await getCurrencyMetadata({ contract: getContract({ - address: tokenAddress as Address, + address: tokenAddressStr as Address, // eslint-disable-next-line no-restricted-syntax - chain: defineChain(Number(chainId)), + chain: defineChain(chainIdNum), client: bridgeAppThirdwebClient, }), }); @@ - <DotsBackgroundPattern /> - <UniversalBridgeEmbed - amount={amount as string} - chainId={chainId ? Number(chainId) : undefined} + <DotsBackgroundPattern /> + <UniversalBridgeEmbed + amount={amountStr} + chainId={chainIdNum} token={ - symbol && decimals && tokenName + symbol && decimals && tokenName ? { - address: tokenAddress as Address, + address: tokenAddressStr as Address, name: tokenName, symbol, } : undefined } />Also applies to: 36-46, 58-73
♻️ Duplicate comments (1)
apps/dashboard/src/app/bridge/components/header.tsx (1)
70-96: De‑duplicate theme toggle by importing the shared component.Use
@/components/blocks/color-mode-toggleinstead of a local ToggleThemeButton; same SSR behavior, less duplication.- <ToggleThemeButton /> + <ToggleThemeButton />Imports:
-import { BookOpenIcon, CoinsIcon, MoonIcon, SunIcon } from "lucide-react"; +import { BookOpenIcon, CoinsIcon } from "lucide-react"; @@ -import { useTheme } from "next-themes"; @@ -import { ClientOnly } from "@/components/blocks/client-only"; -import { Button } from "@/components/ui/button"; -import { Skeleton } from "@/components/ui/skeleton"; +import { ToggleThemeButton } from "@/components/blocks/color-mode-toggle";And remove the local
ToggleThemeButtondefinition at the bottom of the file.
🧹 Nitpick comments (3)
apps/dashboard/src/app/bridge/page.tsx (2)
1-1: Reuse the shared DotsBackgroundPattern instead of re-implementing.Avoid duplication; import the shared UI primitive and pass classes via its
classNameprop.-import { cn } from "@workspace/ui/lib/utils"; +// cn no longer needed after removing local pattern component @@ - <DotsBackgroundPattern /> + <DotsBackgroundPattern className="-inset-x-36 -inset-y-24 text-foreground/20 dark:text-muted-foreground/20 hidden lg:block" /> @@ -function DotsBackgroundPattern(props: { className?: string }) { - return ( - <div - className={cn( - "pointer-events-none absolute -inset-x-36 -inset-y-24 text-foreground/20 dark:text-muted-foreground/20 hidden lg:block", - props.className, - )} - style={{ - backgroundImage: "radial-gradient(currentColor 1px, transparent 1px)", - backgroundSize: "24px 24px", - maskImage: - "radial-gradient(ellipse 100% 100% at 50% 50%, black 30%, transparent 50%)", - }} - /> - ); -} +// Use the shared component +// import at top: +// import { DotsBackgroundPattern } from "@/components/ui/background-patterns";Based on learnings.
Also applies to: 59-60, 117-132
87-107: Optionally expose className on local components for consistency.Consider adding
className?: stringto HeadingSection, DataPill, and BridgeFaqSection root nodes to match our *.tsx guideline and ease composition.Also applies to: 109-115, 162-170
apps/dashboard/src/app/bridge/components/header.tsx (1)
14-23: Expose a className prop on the root wrapper.Align with our *.tsx guideline; keep
containerClassNamefor the inner header.-export function BridgePageHeader(props: { containerClassName?: string }) { +export function BridgePageHeader(props: { + className?: string; + containerClassName?: string; +}) { return ( - <div className="border-b border-border/70"> + <div className={cn("border-b border-border/70", props.className)}> <header
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
apps/dashboard/src/@/analytics/report.ts(1 hunks)apps/dashboard/src/@/components/blocks/faq-section.tsx(1 hunks)apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsx(2 hunks)apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx(3 hunks)apps/dashboard/src/app/bridge/components/client/pill-link.tsx(0 hunks)apps/dashboard/src/app/bridge/components/header.tsx(2 hunks)apps/dashboard/src/app/bridge/page.tsx(3 hunks)
💤 Files with no reviewable changes (1)
- apps/dashboard/src/app/bridge/components/client/pill-link.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
- apps/dashboard/src/@/components/blocks/faq-section.tsx
- apps/dashboard/src/app/(app)/(dashboard)/tokens/components/header.tsx
- apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/(chainPage)/page.tsx
🧰 Additional context used
📓 Path-based instructions (6)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/bridge/page.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/bridge/page.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/*(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLinkfor internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()from@/lib/utilsfor conditional class logic
Use design system tokens (e.g.,bg-card,border-border,text-muted-foreground)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()to retrieve JWT from cookies on server side
UseAuthorization: Bearerheader – never embed tokens in URLs
Return typed results (e.g.,Project[],User[]) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stablequeryKeysfor React Query cache hits
ConfigurestaleTime/cacheTimein React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-jsin server components
Files:
apps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/bridge/page.tsx
apps/{dashboard,playground}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/**/*.{ts,tsx}: Import UI primitives from@/components/ui/_(e.g., Button, Input, Tabs, Card)
UseNavLinkfor internal navigation to get active state handling
Use Tailwind CSS for styling; no inline styles
Merge class names withcn()from@/lib/utilsfor conditional classes
Stick to design tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components must start withimport "server-only"; usenext/headers, server‑only env, heavy data fetching, andredirect()where appropriate
Client Components must start with'use client'; handle interactivity with hooks and browser APIs
Server-side data fetching: callgetAuthToken()from cookies, sendAuthorization: Bearer <token>header, and return typed results (avoidany)
Client-side data fetching: wrap calls in React Query with descriptive, stablequeryKeysand set sensiblestaleTime/cacheTime(≥ 60s default); keep tokens secret via internal routes or server actions
Do not importposthog-jsin server components (client-side only)
Files:
apps/dashboard/src/@/analytics/report.tsapps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/bridge/page.tsx
apps/{dashboard,playground}/src/@/analytics/report.ts
📄 CodeRabbit inference engine (AGENTS.md)
apps/{dashboard,playground}/src/@/analytics/report.ts: Checkreport.tsbefore adding a new analytics event to avoid duplicates
Analytics naming: event name as<subject> <verb>; helper function asreport<Subject><Verb>(PascalCase)
Each analytics helper must include a JSDoc header (Why/Owner), accept a single typedpropertiesobject, and forward it unchanged toposthog.capture
Files:
apps/dashboard/src/@/analytics/report.ts
apps/{dashboard,playground}/**/*.tsx
📄 CodeRabbit inference engine (AGENTS.md)
Expose a
classNameprop on the root element of every component
Files:
apps/dashboard/src/app/bridge/components/header.tsxapps/dashboard/src/app/bridge/page.tsx
🧠 Learnings (4)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to apps/{dashboard,playground}/src/@/analytics/report.ts : Analytics naming: event name as `<subject> <verb>`; helper function as `report<Subject><Verb>` (PascalCase)
Applied to files:
apps/dashboard/src/@/analytics/report.ts
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to src/@/analytics/report.ts : Review `src/@/analytics/report.ts` before adding analytics events to check for duplicates
Applied to files:
apps/dashboard/src/@/analytics/report.ts
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Reuse core UI primitives; avoid re-implementing buttons, cards, modals.
Applied to files:
apps/dashboard/src/app/bridge/components/header.tsx
📚 Learning: 2025-07-18T19:20:32.530Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: .cursor/rules/dashboard.mdc:0-0
Timestamp: 2025-07-18T19:20:32.530Z
Learning: Applies to dashboard/**/*.{tsx,jsx} : Prefer composable primitives over custom markup: `Button`, `Input`, `Select`, `Tabs`, `Card`, `Sidebar`, `Separator`, `Badge`.
Applied to files:
apps/dashboard/src/app/bridge/components/header.tsx
🧬 Code graph analysis (2)
apps/dashboard/src/app/bridge/components/header.tsx (2)
apps/dashboard/src/@/analytics/report.ts (1)
reportBridgePageLinkClick(685-689)apps/dashboard/src/@/components/blocks/color-mode-toggle.tsx (1)
ToggleThemeButton(10-36)
apps/dashboard/src/app/bridge/page.tsx (4)
apps/dashboard/src/app/bridge/components/header.tsx (1)
BridgePageHeader(14-68)apps/dashboard/src/@/components/ui/background-patterns.tsx (1)
DotsBackgroundPattern(4-19)apps/dashboard/src/app/bridge/components/client/UniversalBridgeEmbed.tsx (1)
UniversalBridgeEmbed(19-40)apps/dashboard/src/@/components/blocks/faq-section.tsx (1)
FaqAccordion(8-23)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/dashboard/src/@/analytics/report.ts (1)
685-689: All verification passed; no issues found.
- No legacy "integrate-bridge" usages remain
- Both callsites in header.tsx use new union values ("trending-tokens", "bridge-docs")
- JSDoc includes Why/Owner headers per guidelines
- Event name and function name follow analytics naming conventions
- Payload forwarded unchanged to posthog
apps/dashboard/src/app/bridge/components/header.tsx (1)
34-46: Addrel="noopener noreferrer"to both Links withtarget="_blank".The dashboard codebase consistently applies
rel="noopener noreferrer"to all Links withtarget="_blank", including internal routes. Both the docs link (external, lines 51-57) and the trending tokens link (internal/tokens, lines 34-46) should follow this pattern for consistency and security.<Link onClick={() => { reportBridgePageLinkClick({ linkType: "trending-tokens" }); }} target="_blank" + rel="noopener noreferrer" href="/tokens" className="text-sm text-muted-foreground hover:text-foreground p-2 hover:bg-accent rounded-full transition-all duration-100" > <span className="text-sm sr-only md:not-sr-only"> Trending Tokens </span> <CoinsIcon className="size-5 md:hidden" /> </Link> <Link onClick={() => { reportBridgePageLinkClick({ linkType: "bridge-docs" }); }} href="https://portal.thirdweb.com/bridge" target="_blank" + rel="noopener noreferrer" aria-label="View Documentation" className="text-sm text-muted-foreground hover:text-foreground p-2 hover:bg-accent rounded-full transition-all duration-100" > <BookOpenIcon className="size-5" /> </Link>⛔ Skipped due to learnings
Learnt from: MananTank PR: thirdweb-dev/js#7812 File: apps/dashboard/src/app/(app)/(dashboard)/published-contract/components/token-banner.tsx:48-60 Timestamp: 2025-08-07T20:43:21.864Z Learning: In the TokenBanner component at apps/dashboard/src/app/(app)/(dashboard)/published-contract/components/token-banner.tsx, the Link components use target="_blank" with internal application routes (starting with "/") to open pages in new tabs within the same application. These internal links do not require rel="noopener noreferrer" security attributes, which are only needed for external URLs.Learnt from: MananTank PR: thirdweb-dev/js#7984 File: apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/FeatureCard.client.tsx:93-99 Timestamp: 2025-09-05T19:45:22.949Z Learning: In the thirdweb dashboard project, rel="noopener noreferrer" attributes are not required for external links with target="_blank" in Link components, as confirmed by MananTank.
PR-Codex overview
This PR primarily focuses on refactoring components related to the FAQ section and updating the analytics reporting for bridge page links. It also includes modifications to the header components and their styling.
Detailed summary
FaqSectiontoFaqAccordionand updated its usage.FaqSectionfunction inpage.tsxto wrapFaqAccordion.reportBridgePageLinkClickto include a newlinkType.PageHeadertoBridgePageHeaderand adjusted its layout.HeadingSectioncomponent for improved structure.Summary by CodeRabbit
New Features
UI/Layout Changes