Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 6, 2025


PR-Codex overview

This PR focuses on updating the redirect paths in the redirects.mjs file to streamline payment-related routes, directing them to new bridge endpoints.

Detailed summary

  • Added new redirect paths:
    • "/payments/sell" now redirects to "/bridge/sell"
    • "/payments/swap" now redirects to "/bridge/swap"
    • "/payments/tokens" now redirects to "/bridge/tokens"
    • "/payments/routes" now redirects to "/bridge/routes"

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added redirects so payment URLs now route to corresponding bridge destinations:
      • /payments/sell → /bridge/sell
      • /payments/swap → /bridge/swap
      • /payments/tokens → /bridge/tokens
      • /payments/routes → /bridge/routes
    • Existing bookmarks and shared links to payment pages will continue working and automatically route to the updated locations with no UI changes.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 6, 2025 19:31 Inactive
@vercel
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Oct 7, 2025 11:41am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
nebula Skipped Skipped Oct 7, 2025 11:41am
thirdweb_playground Skipped Skipped Oct 7, 2025 11:41am
thirdweb-www Skipped Skipped Oct 7, 2025 11:41am
wallet-ui Skipped Skipped Oct 7, 2025 11:41am

@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2025

⚠️ No Changeset found

Latest commit: f9283f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 6, 2025
@MananTank MananTank marked this pull request as ready for review October 6, 2025 19:31
@MananTank MananTank requested review from a team as code owners October 6, 2025 19:31
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title Portal: Add missing redirects Portal: Add missing redirects for bridge page Oct 6, 2025
@MananTank MananTank changed the title Portal: Add missing redirects for bridge page Portal: Add missing redirects for bridge pages Oct 6, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

Adds four payment-route redirect entries in apps/portal/redirects.mjs, mapping /payments/sell, /payments/swap, /payments/tokens, and /payments/routes to /bridge/* endpoints; these are returned via the existing createRedirects mechanism. (48 words)

Changes

Cohort / File(s) Summary of Changes
Redirect mappings
apps/portal/redirects.mjs
Added redirects: /payments/sell/bridge/sell, /payments/swap/bridge/swap, /payments/tokens/bridge/tokens, /payments/routes/bridge/routes; integrated into the createRedirects output.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant WebServer
  participant RedirectsModule as Redirects
  note over RedirectsModule #DDEBF7: paymentRedirects table updated
  Client->>WebServer: HTTP GET /payments/sell
  WebServer->>Redirects: createRedirects lookup
  Redirects-->>WebServer: 302 Location: /bridge/sell
  WebServer-->>Client: 302 Redirect to /bridge/sell
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description contains only the untouched template comments and a Codex-generated summary, but it lacks any filled-out sections for the formatted title, reviewer notes, or testing instructions, leaving the required template completely unimplemented. Please replace the placeholder comments with actual content by providing the PR title in the specified format, notes for the reviewer, and clear instructions on how to test these new redirects under the respective headings.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “Portal: Add missing redirects for bridge pages” succinctly captures the primary change of adding new redirect mappings and is fully related to the updates in redirects.mjs, making it clear and concise for anyone reviewing the history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 10-07-portal_add_missing_redirects

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f057770 and f9283f3.

📒 Files selected for processing (1)
  • apps/portal/redirects.mjs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/portal/redirects.mjs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Lint Packages
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.03%. Comparing base (9fbb29d) to head (f9283f3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8201   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         919      919           
  Lines       60569    60569           
  Branches     4126     4126           
=======================================
  Hits        33333    33333           
  Misses      27132    27132           
  Partials      104      104           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.6 KB (0%) 1.3 s (0%) 453 ms (+160.44% 🔺) 1.8 s
thirdweb (cjs) 365.75 KB (0%) 7.4 s (0%) 2 s (+16.61% 🔺) 9.3 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 139 ms (+763.14% 🔺) 254 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 115 ms (+2756.4% 🔺) 125 ms
thirdweb/react (minimal + tree-shaking) 19.13 KB (0%) 383 ms (0%) 132 ms (+1400.54% 🔺) 514 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 6, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Oct 6, 2025
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the redirect mappings in the `redirects.mjs` file, specifically adding new routes for payment-related functionalities.

### Detailed summary
- Added new redirect mappings for:
  - `"/payments/sell"` to `"/bridge/sell"`
  - `"/payments/swap"` to `"/bridge/swap"`
  - `"/payments/tokens"` to `"/bridge/tokens"`
  - `"/payments/routes"` to `"/bridge/routes"`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

* **New Features**
  * Introduced redirects for payment paths to corresponding bridge destinations, ensuring seamless navigation and deep-linking:
    * /payments/sell → /bridge/sell
    * /payments/swap → /bridge/swap
    * /payments/tokens → /bridge/tokens
    * /payments/routes → /bridge/routes
  * Existing bookmarks and shared links to payment pages will continue to work and automatically route to the updated locations, improving consistency and reducing friction without requiring any UI changes.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 10-07-portal_add_missing_redirects branch from f48156e to f057770 Compare October 6, 2025 21:32
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 6, 2025 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 6, 2025 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 6, 2025 21:32 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula October 6, 2025 21:32 Inactive
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the redirect paths in the `redirects.mjs` file to streamline payment-related navigation by adding new routes that point to a `bridge` structure.

### Detailed summary
- Added redirect for `"/payments/sell"` to `"/bridge/sell"`
- Added redirect for `"/payments/swap"` to `"/bridge/swap"`
- Added redirect for `"/payments/tokens"` to `"/bridge/tokens"`
- Added redirect for `"/payments/routes"` to `"/bridge/routes"`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **New Features**
  * Added redirects so payment URLs now route to corresponding bridge destinations:
    * /payments/sell → /bridge/sell
    * /payments/swap → /bridge/swap
    * /payments/tokens → /bridge/tokens
    * /payments/routes → /bridge/routes
  * Existing bookmarks and shared links to payment pages will continue working and automatically route to the updated locations, with no UI changes required.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 10-07-portal_add_missing_redirects branch from f057770 to f9283f3 Compare October 7, 2025 11:30
@vercel vercel bot temporarily deployed to Preview – nebula October 7, 2025 11:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 7, 2025 11:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 7, 2025 11:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 7, 2025 11:31 Inactive
@graphite-app graphite-app bot merged commit f9283f3 into main Oct 7, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 10-07-portal_add_missing_redirects branch October 7, 2025 11:41
@vercel vercel bot temporarily deployed to Production – nebula October 7, 2025 11:41 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 7, 2025 11:41 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 7, 2025 11:41 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 7, 2025 11:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants