Skip to content

[MNY-196] SDK: Add SwapWidget render event #8113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

[MNY-196] SDK: Add SwapWidget render event #8113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/thirdweb/src/react/web/ui/Bridge/swap-widget/SwapWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
"use client";

import { useQuery } from "@tanstack/react-query";
import { useCallback, useEffect, useState } from "react";
import { trackPayEvent } from "../../../../../analytics/track/pay.js";
import type { Buy, Sell } from "../../../../../bridge/index.js";
import type { TokenWithPrices } from "../../../../../bridge/types/Token.js";
import type { ThirdwebClient } from "../../../../../client/client.js";
Expand Down Expand Up @@ -241,6 +243,17 @@ export type SwapWidgetProps = {
* @bridge
*/
export function SwapWidget(props: SwapWidgetProps) {
useQuery({
queryFn: () => {
trackPayEvent({
client: props.client,
event: "ub:ui:swap_widget:render",
});
return true;
},
queryKey: ["swap_widget:render"],
});

Comment on lines +246 to +256
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Do not use React Query to fire-and-forget analytics; this introduces a hard dependency on QueryClientProvider and can double-count or miss events.

  • This will throw at runtime in hosts that haven’t wrapped the app with QueryClientProvider.
  • Static queryKey dedupes across multiple widgets; default refetch/retry can re-fire on focus/reconnect/failure.

Replace with a one-time useEffect:

-  useQuery({
-    queryFn: () => {
-      trackPayEvent({
-        client: props.client,
-        event: "ub:ui:swap_widget:render",
-      });
-      return true;
-    },
-    queryKey: ["swap_widget:render"],
-  });
+  useEffect(() => {
+    void trackPayEvent({
+      client: props.client,
+      event: "ub:ui:swap_widget:render",
+    });
+  }, [props.client]);

If you must keep React Query, at minimum guard against re-fetches and retries and scope the key:

-  useQuery({
-    queryFn: () => {
+  useQuery({
+    queryFn: async () => {
       trackPayEvent({
         client: props.client,
         event: "ub:ui:swap_widget:render",
       });
-      return true;
+      return true;
     },
-    queryKey: ["swap_widget:render"],
+    queryKey: ["swap_widget:render", props.client],
+    staleTime: Infinity,
+    retry: false,
+    refetchOnWindowFocus: false,
+    refetchOnReconnect: false,
   });
🤖 Prompt for AI Agents 
In packages/thirdweb/src/react/web/ui/Bridge/swap-widget/SwapWidget.tsx around
lines 246 to 256, the code uses useQuery to fire-and-forget analytics which
creates a hard dependency on QueryClientProvider and can double-count or miss
events; replace the useQuery block with a one-time useEffect that calls
trackPayEvent on mount (with proper dependency array) so it runs exactly once
and does not rely on React Query, or if you must keep React Query, use a unique,
instance-scoped queryKey and disable retries/refetches (set retry: false,
refetchOnWindowFocus: false, refetchOnReconnect: false) and return a stable
promise to ensure the event is not re-fired.

return (
<SwapWidgetContainer
theme={props.theme}
Expand Down
Loading