Version Packages #8075
Version Packages #8075
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughRemoved a changeset file, bumped versions for nebula, thirdweb, and wagmi-adapter packages, and updated their CHANGELOGs. The thirdweb changelog documents a new SwapWidget prop ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (6)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Add a brief note under 0.2.147.
E.g., “Internal version bump only; no functional changes.” Helps consumers scanning diffs.## 0.2.147 +### Patch Changes +- Internal version bump only; no functional changes.packages/wagmi-adapter/package.json (1)
45-54: Nit: add a size-limit budget to packages/wagmi-adapter/package.json
No "size-limit" section found; add a size-limit config to this package.json to guard against accidental bundle bloat.packages/nebula/package.json (1)
46-56: Optional: add size-limit budgets for packages/nebulaNo "size-limit" section found in packages/nebula/package.json (root package.json checked). Add per-package size budgets or confirm a centralized size-limit to detect bundle-size regressions for the generated SDK.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/honest-hands-clap.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/honest-hands-clap.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (2)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
📚 Learning: 2025-09-18T20:09:57.022Z
Learnt from: MananTank
PR: thirdweb-dev/js#8069
File: apps/playground-web/src/app/bridge/swap-widget/components/types.ts:3-12
Timestamp: 2025-09-18T20:09:57.022Z
Learning: The SwapWidgetPlaygroundOptions type should not include persistTokenSelections - the playground intentionally hardcodes persistTokenSelections={false} and doesn't expose it as a configurable option to users.
Applied to files:
packages/thirdweb/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
packages/thirdweb/package.json (2)
421-421: Version bump looks correct; nothing else changed.
Matches the PR scope. Peer ranges already cover this.
317-346: Resolved — size-limit config exists (no action required)
Budgets are defined in packages/thirdweb/.size-limit.json and CI invokes size‑limit (.github/workflows/CI.yml); no change needed.packages/nebula/package.json (1)
60-60: Nebula patch version bump is consistent with dependency update.
No API surface changes; workspace dep aligns with [email protected].packages/wagmi-adapter/package.json (1)
58-58: Wagmi adapter version bump only; peer ranges already compatible.
thirdwebpeer "^5.85.0" includes 5.106.1.packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry reads well and links the commit.
Accurately lists the dependency bump to [email protected].packages/thirdweb/CHANGELOG.md (1)
3-8: LGTM — tiny wording nit; playground check OK
- Wording: change “to local storage” → “in local storage”.
- Verified: playground hardcodes persistTokenSelections={false} in apps/playground-web/src/app/bridge/swap-widget/components/right-section.tsx:63.
Apply wording tweak:
- Add `persistTokenSelections` prop on `SwapWidget` to allow disabling token selection persistence to local storage + Add `persistTokenSelections` prop on `SwapWidget` to allow disabling token selection persistence in local storage
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8075 +/- ##
=======================================
Coverage 56.34% 56.34%
=======================================
Files 906 906
Lines 59171 59171
Branches 4173 4175 +2
=======================================
Hits 33342 33342
Misses 25723 25723
Partials 106 106
🚀 New features to boost your workflow:
|
joaquim-verges
force-pushed
the
changeset-release/main
branch
from
c888fc7 to
e884659
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
32980f8,7b8ceeb]:[email protected]
Patch Changes
#8069
32980f8Thanks @MananTank! - AddpersistTokenSelectionsprop onSwapWidgetto allow disabling token selection persistence to local storage#8077
7b8ceebThanks @joaquim-verges! - Show policy error for 7702 transactions@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers across multiple packages, adding new changelog entries, and modifying dependency versions for the
thirdwebpackage.Detailed summary
.changeset/smart-mugs-doubt.mdand.changeset/honest-hands-clap.md.versionto5.106.1inpackages/thirdweb/package.json.versionto0.2.50inpackages/nebula/package.json.versionto0.2.147inpackages/wagmi-adapter/package.json.thirdwebversion5.106.1.nebulaversion0.2.50.Summary by CodeRabbit