-
Notifications
You must be signed in to change notification settings - Fork 616
Version Packages #8063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8063
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughVersion and changelog updates for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8063 +/- ##
==========================================
+ Coverage 56.51% 56.53% +0.01%
==========================================
Files 904 904
Lines 58865 58871 +6
Branches 4170 4165 -5
==========================================
+ Hits 33269 33282 +13
+ Misses 25491 25483 -8
- Partials 105 106 +1
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/nebula/package.json (1)
1-61: Add bundle budget via size-limit in package.json.Per guidelines, track the built ESM/CJS entry sizes to prevent regressions.
Apply an example config (tune limits to your baseline; add size-limit as a devDependency at workspace root if not present):
"scripts": { "build": "pnpm clean && pnpm build:cjs && pnpm build:esm && pnpm build:types", "build:cjs": "tsc --project ./tsconfig.build.json --module commonjs --outDir ./dist/cjs --verbatimModuleSyntax false && printf '{\"type\":\"commonjs\"}' > ./dist/cjs/package.json", "build:esm": "tsc --project ./tsconfig.build.json --module es2020 --outDir ./dist/esm && printf '{\"type\": \"module\",\"sideEffects\":false}' > ./dist/esm/package.json", "build:generate": "openapi-ts && pnpm format", "build:types": "tsc --project ./tsconfig.build.json --module esnext --declarationDir ./dist/types --emitDeclarationOnly --declaration --declarationMap", "clean": "rimraf dist", "fix": "biome check ./src --fix", "format": "biome format ./src --write", - "lint": "biome check ./src" + "lint": "biome check ./src", + "size": "size-limit" }, + "size-limit": [ + { "path": "dist/esm/exports/thirdweb.js", "limit": "50 kB gzip" }, + { "path": "dist/cjs/exports/thirdweb.js", "limit": "55 kB gzip" } + ],Please confirm whether size-limit is already configured at the repo root; if so, we can skip per-package config or just add entries there.
packages/thirdweb/CHANGELOG.md (1)
3-8: Clarify acronym and tighten phrasing.
- Spell out “AGW” on first mention to avoid ambiguity in release notes.
- Prefer “requires explicit addition” over “needs explicit adding”.
Apply this wording tweak:
- - [#8062](https://github.com/thirdweb-dev/js/pull/8062) [`f276dcf`](https://github.com/thirdweb-dev/js/commit/f276dcfd766c79149c5302b0207777bcc9f267a0) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Filter out AGW from searchable wallets (needs explicit adding) + - [#8062](https://github.com/thirdweb-dev/js/pull/8062) [`f276dcf`](https://github.com/thirdweb-dev/js/commit/f276dcfd766c79149c5302b0207777bcc9f267a0) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Filter out AGW from searchable wallets (requires explicit addition)packages/wagmi-adapter/package.json (1)
58-58: LGTM: version bump only.Patch release number looks consistent with the PR scope.
Optional: track bundle budget here (if not already elsewhere).
If this package isn’t covered by a central size-limit config, consider adding a package-local "size-limit" entry to keep the adapter’s bundle footprint in check.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Changelog header added; consider a one-liner.Entry 0.2.146 is fine. Optionally add a brief note (e.g., “version bump only”) for completeness.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/wide-flies-raise.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/wide-flies-raise.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/wagmi-adapter/package.jsonpackages/thirdweb/package.jsonpackages/nebula/package.json
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/thirdweb/src/wallets/** : EIP-1193, EIP-5792, EIP-7702 standard support in wallet modules
Applied to files:
packages/thirdweb/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
packages/nebula/package.json (1)
60-60: Patch version bump looks correct.0.2.48 → 0.2.49 aligns with a dependency-only patch release. No issues.
packages/thirdweb/CHANGELOG.md (1)
3-8: Resolved — PR, commit, and version align.
packages/thirdweb/package.json version = 5.105.49; packages/thirdweb/CHANGELOG.md has "## 5.105.49" entry referencing PR #8062 and commit f276dcf (short f276dcf); commit exists in repo.packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry matches dependency bump.Entry 0.2.49 correctly reflects [email protected] and links the commit.
Please confirm the linked commit hash resolves and that packages/nebula/package.json is at 0.2.49 in this PR (it should be, per the release bot).
packages/thirdweb/package.json (1)
420-420: LGTM: patch version bump.No functional/config changes beyond "version".
Double-check the corresponding entry exists in packages/thirdweb/CHANGELOG.md for 5.105.49 (it should reference filtering AGW from searchable wallets).
b06693a to
f1bdef5
Compare
f1bdef5 to
042ee2d
Compare
042ee2d to
273adb4
Compare
273adb4 to
d644c12
Compare
d644c12 to
0516c90
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Minor Changes
#8044
0e3f346Thanks @MananTank! - AddSwapWidgetcomponent for swapping tokens using thirdweb BridgePatch Changes
#8066
e160debThanks @joaquim-verges! - Always reconnect any previously connected wallet properly#8067
e0738d6Thanks @MananTank! - Fix SwapWidget setting same token for buy and sell in some cases when using last used token from storage#8065
a6f846fThanks @MananTank! - Addtw-class names in connect ui#8054
15f0839Thanks @MananTank! - FixonSuccesscallback was not called correctly onCheckoutWidget,BuyWidgetcomponents#8062
f276dcfThanks @joaquim-verges! - Filter out AGW from searchable wallets (needs explicit adding)@thirdweb-dev/[email protected]
Patch Changes
e160deb,e0738d6,0e3f346,a6f846f,15f0839,f276dcf]:@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers across several packages and enhancing the
thirdweblibrary with new features and fixes. It includes the removal of old changelogs and the addition of new entries for version updates.Detailed summary
.changesetmarkdown files.versioninpackages/thirdweb/package.jsonfrom5.105.48to5.106.0.versioninpackages/nebula/package.jsonfrom0.2.48to0.2.49.versioninpackages/wagmi-adapter/package.jsonfrom0.2.145to0.2.146.packages/nebulaandpackages/thirdweb.SwapWidgetcomponent inthirdwebfor token swapping.CheckoutWidgetandBuyWidgetcomponents.