-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #8049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #8049
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved a changeset file, bumped package versions for nebula, thirdweb, and wagmi-adapter, and added corresponding changelog entries. No source code or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (1)
Comment |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8049 +/- ##
=======================================
Coverage 56.52% 56.53%
=======================================
Files 904 904
Lines 58864 58864
Branches 4166 4166
=======================================
+ Hits 33275 33280 +5
+ Misses 25483 25478 -5
Partials 106 106
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Add a brief note under 0.2.144 for clarity.Empty entry is fine, but a one‑liner helps consumers scanning the log.
## 0.2.144 + +### Patch Changes +- Version bump only via Changesets; no source changes in wagmi-adapter.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
.changeset/fuzzy-suits-wear.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/fuzzy-suits-wear.md
🧰 Additional context used
📓 Path-based instructions (2)
**/package.json
📄 CodeRabbit inference engine (AGENTS.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/nebula/package.jsonpackages/wagmi-adapter/package.jsonpackages/thirdweb/package.json
packages/wagmi-adapter/**
📄 CodeRabbit inference engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
🧠 Learnings (2)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
packages/nebula/CHANGELOG.md
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/package.jsonpackages/wagmi-adapter/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Analyze (javascript)
🔇 Additional comments (9)
packages/nebula/package.json (2)
60-60: Nebula version bump looks good.No API surface changes; aligns with dependency update to [email protected].
46-56: Add size-limit budget for packages/nebula or confirm central coverage
- Repo search: "size-limit" exists at packages/thirdweb/package.json and packages/thirdweb/.size-limit.json; CI uses size-limit-action in .github/workflows/CI.yml. packages/nebula/package.json has no "size-limit" entry.
- Action: either add a package.json#size-limit entry (or a .size-limit.json) to packages/nebula so it’s tracked, or confirm which central budget (packages/thirdweb or root) already includes nebula and that CI will cover it.
packages/wagmi-adapter/package.json (2)
58-58: Wagmi adapter version bump LGTM.Peer range "^5.85.0" already admits thirdweb 5.105.47; no contract issues.
45-54: Add size-limit or confirm central config for packages/wagmi-adapterpackages/wagmi-adapter/package.json has no "size-limit". The repo contains packages/thirdweb/.size-limit.json and CI uses the size-limit action, while root package.json has no top-level "size-limit". Either add a per-package size-limit entry to packages/wagmi-adapter/package.json or confirm packages/thirdweb/.size-limit.json intentionally covers wagmi-adapter and will be picked up by CI.
packages/thirdweb/package.json (2)
420-420: Core package version bump LGTM.Patch release matches the fiat-payments fix; no export changes.
317-345: Ensure size-limit budgets are configured and enforced in CI.
packages/thirdweb/.size-limit.json exists — confirm CI executes this package's "size" script (runs size-limit) to gate PRs; if it doesn't, add a workflow step to run the size check for packages/thirdweb.packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry reads correctly for a patch dependency bump.Links and versions look consistent with the release notes.
Quick check that commit 97e5080 renders and matches PR #8048 when viewing on GitHub.
packages/thirdweb/CHANGELOG.md (1)
3-8: Changelog entry LGTM.Formatting, links, and version placement match the existing style.
packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Verified — CHANGELOG and package.json versions match (0.2.144)
packages/wagmi-adapter/package.json and packages/wagmi-adapter/CHANGELOG.md both list 0.2.144 as the topmost entry.
befb58f to
f14c85d
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
97e5080]:[email protected]
Patch Changes
97e5080Thanks @joaquim-verges! - Fix fiat payments with no wallets connected@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers across multiple packages and includes changelog entries reflecting these updates, particularly for
thirdweb,nebula, andwagmi-adapter.Detailed summary
fuzzy-suits-wear.mdfrom.changeset.versioninpackages/thirdweb/package.jsonfrom5.105.46to5.105.47.versioninpackages/nebula/package.jsonfrom0.2.46to0.2.47.versioninpackages/wagmi-adapter/package.jsonfrom0.2.143to0.2.144.nebulaandthirdwebreflecting the new versions and associated changes.Summary by CodeRabbit