[BLD-271] Portal: Change Header nav link order #8013
Conversation
|
WalkthroughReordered top navigation items in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks (4 passed, 1 warning)❌ Failed Checks (1 warning)
✅ Passed Checks (4 passed)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
🧪 Generate unit tests
Comment |
github-actions
bot
added
the
Portal
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8013 +/- ##
=======================================
Coverage 56.65% 56.65%
=======================================
Files 904 904
Lines 58677 58677
Branches 4165 4165
=======================================
Hits 33241 33241
Misses 25330 25330
Partials 106 106
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/portal/src/app/Header.tsx (1)
235-241: Add rel="noopener noreferrer" for external links and avoid empty target strings.External links opened with target="_blank" should include rel="noopener noreferrer". Also, prefer undefined over "" for non-external targets.
Apply these diffs:
@@ - <Link + <Link className="text-foreground" href="https://github.com/thirdweb-dev" - target="_blank" + target="_blank" + rel="noopener noreferrer" >@@ - <Link + <Link className="before:absolute before:inset-0" href={info.href} prefetch={false} - target={info.href.startsWith("http") ? "_blank" : ""} + target={info.href.startsWith("http") ? "_blank" : undefined} + rel={info.href.startsWith("http") ? "noopener noreferrer" : undefined} >@@ - <Link + <Link className={clsx( @@ href={props.href} onClick={props.onClick} - target={props.href.startsWith("http") ? "_blank" : ""} + target={props.href.startsWith("http") ? "_blank" : undefined} + rel={props.href.startsWith("http") ? "noopener noreferrer" : undefined} >Also applies to: 478-482, 530-541
🧹 Nitpick comments (2)
apps/portal/src/app/Header.tsx (2)
42-49: Order matches BLD-271 target sequence.The products now render as: Wallets → Transactions → Contracts → Payments → Bridge → Tokens in both desktop and mobile menus via the shared links array. Looks good.
Quick checks:
- Desktop: verify the order on "/" and that the underline highlights correctly for /payments and /bridge.
- Mobile: open burger menu and confirm the same order under “Products”.
I can add a small Playwright test to assert the visible order if you’d like.
529-551: Expose active state to screen readers.Add aria-current to the active nav item.
<Link className={clsx( "font-medium text-base transition-colors hover:text-foreground xl:text-sm", pathname?.startsWith(props.href) ? "text-foreground" : "text-muted-foreground", props.icon ? "flex flex-row gap-3" : "", )} href={props.href} onClick={props.onClick} target={props.href.startsWith("http") ? "_blank" : undefined} + aria-current={pathname?.startsWith(props.href) ? "page" : undefined} >
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/portal/src/app/Header.tsx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/typesor localtypes.tsbarrels
Prefer type aliases over interface except for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial,Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
**/*.{ts,tsx}: Use explicit function declarations and explicit return types in TypeScript
Limit each file to one stateless, single‑responsibility function
Re‑use shared types from@/typeswhere applicable
Prefertypealiases overinterfaceexcept for nominal shapes
Avoidanyandunknownunless unavoidable; narrow generics when possible
Prefer composition over inheritance; use utility types (Partial, Pick, etc.)
Lazy‑import optional features and avoid top‑level side‑effects to reduce bundle size
Files:
apps/portal/src/app/Header.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/portal/src/app/Header.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/portal/src/app/Header.tsx (1)
139-141: Label/URL mismatch for “Payments” in APIs dropdown.APIs list shows “Payments” but points to bridge.thirdweb.com/reference. Please confirm whether this should be “Bridge” or the href should be a Payments docs URL.
size-limit report 📦
|
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on modifying the `links` array in the `Header.tsx` file by removing and then re-adding the `Payments` and `Bridge` items, thereby changing their order within the array.
### Detailed summary
- Removed `Payments` link from the `links` array.
- Removed `Bridge` link from the `links` array.
- Re-added `Payments` link to the `links` array.
- Re-added `Bridge` link to the `links` array.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Style**
* Updated top navigation order: Payments and Bridge now appear after Contracts instead of immediately after Wallets.
* Applies to both desktop navigation and the mobile menu, improving consistency across views without changing the available links or destinations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
09-09-_bld-271_portal_change_header_nav_link_order
branch
from
7568646 to
88001cf
Compare
graphite-app
bot
deleted the
09-09-_bld-271_portal_change_header_nav_link_order
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
PR-Codex overview
This PR focuses on updating the
linksarray in theHeader.tsxfile by removing and then re-adding thePaymentsandBridgelinks, effectively reorganizing the structure.Detailed summary
Paymentslink from thelinksarray.Bridgelink from thelinksarray.Paymentslink with the same properties.Bridgelink with the same properties.Summary by CodeRabbit