Skip to content

Conversation

@nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Sep 8, 2025

PR-Codex overview

This PR focuses on a patch for the thirdweb library, specifically addressing an issue with the Polygon amoy gas station URL.

Detailed summary

  • Added a patch for the thirdweb library.
  • Fixed the URL for the Polygon amoy gas station.
  • Related to GitHub PR 8004.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Fixed the Polygon Amoy gas station endpoint, improving gas price fetching, estimations, and transaction reliability on that network.
  • Chores

    • Prepared a patch release entry to publish the fix.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2025

🦋 Changeset detected

Latest commit: 4ff1cf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

Walkthrough

Adds a new changeset file marking a patch release for the "thirdweb" package with description "Polygon amoy gasstation url fix" and a reference link to PR #8004. No source code or API changes.

Changes

Cohort / File(s) Summary
Release metadata
`.changeset/huge-bees-tan.md`
Added changeset marking a patch release for "thirdweb" with description and PR link.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch np/changeset

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Ready Preview Comment Sep 8, 2025 6:50pm
nebula Ready Ready Preview Comment Sep 8, 2025 6:50pm
thirdweb_playground Ready Ready Preview Comment Sep 8, 2025 6:50pm
thirdweb-www Ready Ready Preview Comment Sep 8, 2025 6:50pm
wallet-ui Ready Ready Preview Comment Sep 8, 2025 6:50pm

Copy link
Member

@0xFirekeeper 0xFirekeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch

@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.65%. Comparing base (e78a984) to head (4ff1cf7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8007   +/-   ##
=======================================
  Coverage   56.65%   56.65%           
=======================================
  Files         904      904           
  Lines       58677    58677           
  Branches     4165     4165           
=======================================
  Hits        33241    33241           
  Misses      25330    25330           
  Partials      106      106           
Flag Coverage Δ
packages 56.65% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.changeset/stale-deer-do.md (2)

5-5: Polish the release note wording.

Capitalize proper nouns, use “gas station” (two words), and end with a period. Optionally add brief context (e.g., chain/network).

-Fix polygon amoy gasstation url
+Fix Polygon Amoy gas station URL.

1-5: Confirm the targeted package is correct.

Ensure the code change that updates the Polygon Amoy gas station URL lives in the packages/thirdweb package (or include additional packages in this changeset if the fix spans more than one).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e78a984 and d2403a0.

📒 Files selected for processing (1)
  • .changeset/stale-deer-do.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

.changeset/*.md: Each change in packages/* must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API

Files:

  • .changeset/stale-deer-do.md
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package

Applied to files:

  • .changeset/stale-deer-do.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API

Applied to files:

  • .changeset/stale-deer-do.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Size
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
.changeset/stale-deer-do.md (1)

1-3: Use patch bump for non-API bugfix
This changeset declares a major release, but the note describes only a URL fix with no public API change. Per our versioning rules, set the bump to patch:

---
-"thirdweb": major
+"thirdweb": patch
---

If this does include a breaking change, keep major and add explicit BREAKING details in the body.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.96 KB (0%) 1.3 s (0%) 402 ms (+103.09% 🔺) 1.7 s
thirdweb (cjs) 356.86 KB (0%) 7.2 s (0%) 1.6 s (+5.38% 🔺) 8.8 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 169 ms (+1517.13% 🔺) 284 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 152 ms (+3721.43% 🔺) 162 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 157 ms (+445.86% 🔺) 540 ms

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/fuzzy-aliens-float.md (1)

5-6: Polish copy, fix PR reference, and avoid bare URL (MD034).

Use proper casing/wording and link to this PR (#8007) instead of #8004.

Apply this diff:

-Polygon amoy gasstation url fix
-https://github.com/thirdweb-dev/js/pull/8004
+Fix Polygon Amoy gas station URL.
+See [PR #8007](https://github.com/thirdweb-dev/js/pull/8007).
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d2403a0 and 1fa00a7.

📒 Files selected for processing (1)
  • .changeset/fuzzy-aliens-float.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

.changeset/*.md: Each change in packages/* must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API

Files:

  • .changeset/fuzzy-aliens-float.md
🧠 Learnings (1)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API

Applied to files:

  • .changeset/fuzzy-aliens-float.md
🪛 markdownlint-cli2 (0.17.2)
.changeset/fuzzy-aliens-float.md

6-6: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Size

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/huge-bees-tan.md (1)

5-6: Polish wording, capitalization, and avoid bare URL (MD034).

Use imperative mood, proper casing (URL), and Markdown link.

Apply:

-Polygon amoy gasstation url fix
-https://github.com/thirdweb-dev/js/pull/8004
+Fix Polygon Amoy gas station URL.
+See [thirdweb-dev/js#8004](https://github.com/thirdweb-dev/js/pull/8004).
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1fa00a7 and 6bad830.

📒 Files selected for processing (1)
  • .changeset/huge-bees-tan.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

.changeset/*.md: Each change in packages/* must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API

Files:

  • .changeset/huge-bees-tan.md
🧠 Learnings (1)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API

Applied to files:

  • .changeset/huge-bees-tan.md
🪛 markdownlint-cli2 (0.17.2)
.changeset/huge-bees-tan.md

6-6: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
.changeset/huge-bees-tan.md (2)

1-3: Changeset frontmatter is valid.

Correct package key and bump type syntax for Changesets.


2-2: Patch bump seems correct; PR summary says “minor” — please reconcile.

Per guidelines (patch for non‑API changes; minor for public API changes), a URL fix should be patch. Either update the PR title/description to “patch” or confirm if any API surfaced changes require a minor bump.

Would you like me to update the PR description text to reflect a patch bump?

@nischitpra nischitpra added the merge-queue Adds the pull request to Graphite's merge queue. label Sep 8, 2025 — with Graphite App
Copy link
Contributor Author

nischitpra commented Sep 8, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on a patch for the `thirdweb` library that addresses a fix for the Polygon amoy gas station URL.

### Detailed summary
- Introduced a patch for the `thirdweb` library.
- Fixed the URL for the Polygon amoy gas station.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Bug Fixes**
  * Corrected the Polygon Amoy gas station endpoint, improving fee estimation and transaction reliability on that network.

* **Chores**
  * Prepared a patch release entry reflecting this fix.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/huge-bees-tan.md (1)

5-6: Fix casing and markdownlint MD034 (bare URL); also verify PR link.

Use sentence case and wrap the URL; update the link to this PR if intended.

-Polygon amoy gasstation url fix
-https://github.com/thirdweb-dev/js/pull/8004
+Fix Polygon Amoy gas station URL
+<https://github.com/thirdweb-dev/js/pull/8007>
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e78a984 and 4ff1cf7.

📒 Files selected for processing (1)
  • .changeset/huge-bees-tan.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md

📄 CodeRabbit inference engine (AGENTS.md)

.changeset/*.md: Each change in packages/* must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API

Files:

  • .changeset/huge-bees-tan.md
🧠 Learnings (1)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API

Applied to files:

  • .changeset/huge-bees-tan.md
🪛 markdownlint-cli2 (0.17.2)
.changeset/huge-bees-tan.md

6-6: Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
.changeset/huge-bees-tan.md (2)

2-3: Patch bump is appropriate.

Non-API URL fix → patch is correct per guidelines.


2-3: Confirm correct package scope.

Ensure “thirdweb” is the intended package for the change; if the URL lives under a different package (e.g., a chain config subpackage), adjust the changeset target accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants