-
Notifications
You must be signed in to change notification settings - Fork 619
fix polygon amoy gasstation url #8007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4ff1cf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughAdds a new changeset file marking a patch release for the "thirdweb" package with description "Polygon amoy gasstation url fix" and a reference link to PR #8004. No source code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xFirekeeper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8007 +/- ##
=======================================
Coverage 56.65% 56.65%
=======================================
Files 904 904
Lines 58677 58677
Branches 4165 4165
=======================================
Hits 33241 33241
Misses 25330 25330
Partials 106 106
🚀 New features to boost your workflow:
|
d2403a0 to
1fa00a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/stale-deer-do.md (2)
5-5: Polish the release note wording.Capitalize proper nouns, use “gas station” (two words), and end with a period. Optionally add brief context (e.g., chain/network).
-Fix polygon amoy gasstation url +Fix Polygon Amoy gas station URL.
1-5: Confirm the targeted package is correct.Ensure the code change that updates the Polygon Amoy gas station URL lives in the
packages/thirdwebpackage (or include additional packages in this changeset if the fix spans more than one).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/stale-deer-do.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
.changeset/*.md: Each change inpackages/*must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API
Files:
.changeset/stale-deer-do.md
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Each change in `packages/*` must include a changeset for the appropriate package
Applied to files:
.changeset/stale-deer-do.md
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
.changeset/stale-deer-do.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
.changeset/stale-deer-do.md (1)
1-3: Use patch bump for non-API bugfix
This changeset declares a major release, but the note describes only a URL fix with no public API change. Per our versioning rules, set the bump to patch:--- -"thirdweb": major +"thirdweb": patch ---If this does include a breaking change, keep
majorand add explicit BREAKING details in the body.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.changeset/fuzzy-aliens-float.md (1)
5-6: Polish copy, fix PR reference, and avoid bare URL (MD034).Use proper casing/wording and link to this PR (#8007) instead of #8004.
Apply this diff:
-Polygon amoy gasstation url fix -https://github.com/thirdweb-dev/js/pull/8004 +Fix Polygon Amoy gas station URL. +See [PR #8007](https://github.com/thirdweb-dev/js/pull/8007).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/fuzzy-aliens-float.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
.changeset/*.md: Each change inpackages/*must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API
Files:
.changeset/fuzzy-aliens-float.md
🧠 Learnings (1)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
.changeset/fuzzy-aliens-float.md
🪛 markdownlint-cli2 (0.17.2)
.changeset/fuzzy-aliens-float.md
6-6: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Size
1fa00a7 to
6bad830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/huge-bees-tan.md (1)
5-6: Polish wording, capitalization, and avoid bare URL (MD034).Use imperative mood, proper casing (URL), and Markdown link.
Apply:
-Polygon amoy gasstation url fix -https://github.com/thirdweb-dev/js/pull/8004 +Fix Polygon Amoy gas station URL. +See [thirdweb-dev/js#8004](https://github.com/thirdweb-dev/js/pull/8004).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/huge-bees-tan.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
.changeset/*.md: Each change inpackages/*must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API
Files:
.changeset/huge-bees-tan.md
🧠 Learnings (1)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
.changeset/huge-bees-tan.md
🪛 markdownlint-cli2 (0.17.2)
.changeset/huge-bees-tan.md
6-6: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
.changeset/huge-bees-tan.md (2)
1-3: Changeset frontmatter is valid.Correct package key and bump type syntax for Changesets.
2-2: Patch bump seems correct; PR summary says “minor” — please reconcile.Per guidelines (patch for non‑API changes; minor for public API changes), a URL fix should be patch. Either update the PR title/description to “patch” or confirm if any API surfaced changes require a minor bump.
Would you like me to update the PR description text to reflect a patch bump?
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on a patch for the `thirdweb` library that addresses a fix for the Polygon amoy gas station URL.
### Detailed summary
- Introduced a patch for the `thirdweb` library.
- Fixed the URL for the Polygon amoy gas station.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Bug Fixes**
* Corrected the Polygon Amoy gas station endpoint, improving fee estimation and transaction reliability on that network.
* **Chores**
* Prepared a patch release entry reflecting this fix.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
6bad830 to
4ff1cf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/huge-bees-tan.md (1)
5-6: Fix casing and markdownlint MD034 (bare URL); also verify PR link.Use sentence case and wrap the URL; update the link to this PR if intended.
-Polygon amoy gasstation url fix -https://github.com/thirdweb-dev/js/pull/8004 +Fix Polygon Amoy gas station URL +<https://github.com/thirdweb-dev/js/pull/8007>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/huge-bees-tan.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit inference engine (AGENTS.md)
.changeset/*.md: Each change inpackages/*must include a changeset for the appropriate package
Version bump rules: patch for non‑API changes; minor for new/modified public API
Files:
.changeset/huge-bees-tan.md
🧠 Learnings (1)
📚 Learning: 2025-08-29T15:37:38.513Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: AGENTS.md:0-0
Timestamp: 2025-08-29T15:37:38.513Z
Learning: Applies to .changeset/*.md : Version bump rules: patch for non‑API changes; minor for new/modified public API
Applied to files:
.changeset/huge-bees-tan.md
🪛 markdownlint-cli2 (0.17.2)
.changeset/huge-bees-tan.md
6-6: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Lint Packages
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
.changeset/huge-bees-tan.md (2)
2-3: Patch bump is appropriate.Non-API URL fix → patch is correct per guidelines.
2-3: Confirm correct package scope.Ensure “thirdweb” is the intended package for the change; if the URL lives under a different package (e.g., a chain config subpackage), adjust the changeset target accordingly.
PR-Codex overview
This PR focuses on a patch for the
thirdweblibrary, specifically addressing an issue with the Polygonamoygas station URL.Detailed summary
thirdweblibrary.amoygas station.Summary by CodeRabbit
Bug Fixes
Chores