Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Aug 11, 2025


PR-Codex overview

This PR focuses on renaming various instances of "Payment Link" to "Payment" across the application, enhancing clarity and consistency in terminology related to payment functionalities.

Detailed summary

  • Renamed name from "Links" to "Create" in layout.tsx.
  • Updated button text from "Create Payment Link" to "Create Payment" in multiple components.
  • Changed headings and descriptions to reflect the new terminology.
  • Adjusted success and error messages to use "Payment" instead of "Payment Link".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Renamed “Payment Links” to “Payments” throughout the dashboard: tab label, page headers/descriptions, buttons, table column, dialogs, delete confirmations, and empty states.
    • Updated Quickstart copy to emphasize hosted payment UIs and prebuilt components.
    • Refreshed success and deletion toast messages to align with the new terminology (e.g., “Payment created successfully.” / “Payment deleted successfully.”).
    • Adjusted Recent Payments empty state link from “Create Payment Link” to “Create Payment” for consistency.

@gregfromstl gregfromstl requested review from a team as code owners August 11, 2025 18:35
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025

⚠️ No Changeset found

Latest commit: 7e9c64f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 11, 2025

Walkthrough

This PR updates UI copy to rename “Payment Links” to “Payments” across multiple dashboard components, including feature cards, empty states, tabs, dialogs, tables, and page headers/descriptions. It also adds a key prop to a button. No logic, routing, data flow, or exported API signatures are changed.

Changes

Cohort / File(s) Summary of changes
Payments overview copy
apps/dashboard/src/app/(app)/team/.../payments/components/QuickstartSection.client.tsx, apps/dashboard/src/app/(app)/team/.../payments/components/RecentPaymentsSection.client.tsx
Renamed “Payment Links” to “Payments” in feature card titles/descriptions and empty-state link label.
Payments navigation/tab label
apps/dashboard/src/app/(app)/team/.../payments/layout.tsx
Tab label changed from “Links” to “Create”; paths unchanged.
Create Payment dialog and form
apps/dashboard/src/app/(app)/team/.../payments/links/components/CreatePaymentLinkButton.client.tsx, apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx
Dialog titles and success toasts updated from “Payment Link” to “Payment”; no functional changes.
Payments list/table and page
apps/dashboard/src/app/(app)/team/.../payments/links/components/PaymentLinksTable.client.tsx, apps/dashboard/src/app/(app)/team/.../payments/links/page.tsx
Table headers, empty-state text, button labels, delete-confirmation, and success toast updated from “payment link(s)” to “payment(s)”; page header/description updated; added key prop to button.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

Dashboard

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/update-payment-link-copy

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Aug 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@vercel
Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2025 6:43pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Aug 11, 2025 6:43pm
nebula ⬜️ Skipped (Inspect) Aug 11, 2025 6:43pm
thirdweb_playground ⬜️ Skipped (Inspect) Aug 11, 2025 6:43pm
wallet-ui ⬜️ Skipped (Inspect) Aug 11, 2025 6:43pm

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.32%. Comparing base (90f36bc) to head (7e9c64f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7831   +/-   ##
=======================================
  Coverage   56.32%   56.32%           
=======================================
  Files         905      905           
  Lines       58820    58820           
  Branches     4148     4148           
=======================================
  Hits        33133    33133           
  Misses      25581    25581           
  Partials      106      106           
Flag Coverage Δ
packages 56.32% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.03 KB (0%) 1.3 s (0%) 217 ms (+86.71% 🔺) 1.5 s
thirdweb (cjs) 357.38 KB (0%) 7.2 s (0%) 415 ms (-4.28% 🔽) 7.6 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 127 ms (+907.98% 🔺) 241 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 80 ms (+979.57% 🔺) 90 ms
thirdweb/react (minimal + tree-shaking) 19.16 KB (0%) 384 ms (0%) 109 ms (+181.53% 🔺) 492 ms

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/layout.tsx (1)

53-53: Consider updating the path to match the new tab label.

The tab label changed from "Links" to "Create" but the path remains /links. This creates a disconnect between the UI label and the URL structure, which could be confusing for users and developers.

Consider updating the path to align with the new terminology:

- name: "Create",
- path: `${payLayoutPath}/links`,
+ name: "Create",
+ path: `${payLayoutPath}/create`,

Note: This would require updating the corresponding route file structure.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90f36bc and 7e9c64f.

📒 Files selected for processing (7)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/QuickstartSection.client.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/RecentPaymentsSection.client.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/layout.tsx (1 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/CreatePaymentLinkButton.client.tsx (2 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/PaymentLinksTable.client.tsx (5 hunks)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/page.tsx (2 hunks)
  • apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

Files:

  • apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/QuickstartSection.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/layout.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/RecentPaymentsSection.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/CreatePaymentLinkButton.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/PaymentLinksTable.client.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

  • apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/QuickstartSection.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/layout.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/RecentPaymentsSection.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/CreatePaymentLinkButton.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/PaymentLinksTable.client.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from @/components/ui/* (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
Use NavLink for internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Use cn() from @/lib/utils for conditional class logic
Use design system tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components (Node edge): Start files with import "server-only";
Client Components (browser): Begin files with 'use client';
Always call getAuthToken() to retrieve JWT from cookies on server side
Use Authorization: Bearer header – never embed tokens in URLs
Return typed results (e.g., Project[], User[]) – avoid any
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stable queryKeys for React Query cache hits
Configure staleTime/cacheTime in React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never import posthog-js in server components

Files:

  • apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/QuickstartSection.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/layout.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/RecentPaymentsSection.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/page.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/CreatePaymentLinkButton.client.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/PaymentLinksTable.client.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Unit Tests
  • GitHub Check: Build Packages
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (10)
apps/dashboard/src/app/pay/components/client/PaymentLinkForm.client.tsx (1)

119-119: LGTM! Consistent terminology updates.

The toast message and card title updates align perfectly with the PR objective of renaming "payment links" to "payments". The changes maintain consistency across the user experience.

Also applies to: 191-191

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/RecentPaymentsSection.client.tsx (1)

103-103: LGTM! Consistent UI text update.

The link label change from "Create Payment Link" to "Create Payment" aligns with the PR's renaming objective while correctly maintaining the existing href structure.

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/CreatePaymentLinkButton.client.tsx (1)

110-110: LGTM! Consistent dialog and toast updates.

Both the success toast message and dialog title updates align perfectly with the PR's objective of renaming "payment links" to "payments". The changes maintain consistency in the user interface.

Also applies to: 172-172

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/page.tsx (2)

26-26: LGTM! Comprehensive and consistent updates.

The header, description, and button text updates all align perfectly with the PR's renaming objective. The terminology is now consistent throughout the component.

Also applies to: 29-29, 39-39


33-33: Good addition of key prop.

Adding the key prop to the CreatePaymentLinkButton component follows React best practices and helps with component identity.

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/QuickstartSection.client.tsx (2)

23-24: LGTM! Improved terminology and clarity.

The title and description updates not only align with the PR's renaming objective but also better describe the functionality by emphasizing "hosted payment UIs" rather than just "shareable URLs".


62-62: Nice typo fix!

Correcting "prebuild" to "prebuilt" improves the professional appearance of the UI text.

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/links/components/PaymentLinksTable.client.tsx (3)

104-105: LGTM! Consistent empty state and button updates.

The empty state title, description, and button text updates all align perfectly with the PR's renaming objective, ensuring a consistent user experience when no payments are configured.

Also applies to: 114-114


128-128: LGTM! Table header consistency.

The table header update from "Payment Link" to "Payment" maintains consistency with the new terminology throughout the interface.


277-277: LGTM! Consistent delete dialog and toast messages.

The dialog description and success toast updates ensure the delete flow uses consistent terminology with the rest of the interface.

Also applies to: 293-293

@gregfromstl gregfromstl merged commit c661a48 into main Aug 11, 2025
25 checks passed
@gregfromstl gregfromstl deleted the fix/update-payment-link-copy branch August 11, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants