Skip to content

[SDK] Fix: Adds onExecuteTransaction to TransactionPayment #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2025
Merged

[SDK] Fix: Adds onExecuteTransaction to TransactionPayment #7816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c570dd9
fix: adds onExecuteTransaction to TransactionPayment
gregfromstl Aug 8, 2025
41fe40a
fix build
gregfromstl Aug 8, 2025
5e3d387
for the love of god
gregfromstl Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/thirdweb/src/react/core/machines/paymentMachine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export interface PaymentMachineContext {
/**
* Events that can be sent to the payment machine
*/
export type PaymentMachineEvent =
type PaymentMachineEvent =
| {
type: "DESTINATION_CONFIRMED";
destinationToken: Token;
Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/react/web/ui/Bridge/BridgeOrchestrator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ export function BridgeOrchestrator({
client={client}
connectOptions={modifiedConnectOptions}
onContinue={handleRequirementsResolved}
sendEvent={send}
onExecuteTransaction={() => send({ type: "CONTINUE_TO_TRANSACTION" })}
showThirdwebBranding={showThirdwebBranding}
uiOptions={uiOptions}
/>
Expand Down
11 changes: 4 additions & 7 deletions packages/thirdweb/src/react/web/ui/Bridge/TransactionPayment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { useChainMetadata } from "../../../core/hooks/others/useChainQuery.js";
import { useTransactionDetails } from "../../../core/hooks/useTransactionDetails.js";
import { useActiveAccount } from "../../../core/hooks/wallets/useActiveAccount.js";
import { useActiveWallet } from "../../../core/hooks/wallets/useActiveWallet.js";
import type { PaymentMachineEvent } from "../../../core/machines/paymentMachine.js";
import { ConnectButton } from "../ConnectWallet/ConnectButton.js";
import { PoweredByThirdweb } from "../ConnectWallet/PoweredByTW.js";
import { Container, Line } from "../components/basic.js";
Expand Down Expand Up @@ -50,9 +49,9 @@ export interface TransactionPaymentProps {
onContinue: (amount: string, token: Token, receiverAddress: Address) => void;

/**
* Send arbitrary payment events for UI flow control
* Request to execute the transaction immediately (skips funding flow)
*/
sendEvent: (event: PaymentMachineEvent) => void;
onExecuteTransaction: () => void;

/**
* Connect options for wallet connection
Expand All @@ -70,7 +69,7 @@ export function TransactionPayment({
uiOptions,
client,
onContinue,
sendEvent,
onExecuteTransaction,
connectOptions,
showThirdwebBranding = true,
}: TransactionPaymentProps) {
Expand Down Expand Up @@ -391,9 +390,7 @@ export function TransactionPayment({
Number(userBalance) >=
Number(transactionDataQuery.data.totalCost)
) {
sendEvent({
type: "CONTINUE_TO_TRANSACTION",
});
onExecuteTransaction();
return;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/thirdweb/src/stories/Bridge/TransactionPayment.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const TransactionPaymentWithTheme = (
const meta = {
args: {
client: storyClient,
sendEvent: (_event) => {},
onExecuteTransaction: () => {},
onContinue: (_amount, _token, _receiverAddress) => {},
theme: "dark",
uiOptions: TRANSACTION_UI_OPTIONS.ethTransfer,
Expand Down
Loading