-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Fix: Bridge.tokens domain #7815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix: Bridge.tokens domain #7815
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Caution Review failedThe pull request is closed. WalkthroughThe change updates how the base URL for bridge token API endpoints is determined in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7815 +/- ##
==========================================
- Coverage 56.33% 56.32% -0.02%
==========================================
Files 905 905
Lines 58809 58823 +14
Branches 4147 4145 -2
==========================================
+ Hits 33131 33132 +1
- Misses 25573 25585 +12
- Partials 105 106 +1
🚀 New features to boost your workflow:
|
size-limit report 📦
|
PR-Codex overview
This PR updates the way the base URL for the
bridgeendpoint is constructed in theToken.tsfile. It replaces the usage ofgetThirdwebDomainswithgetThirdwebBaseUrlfor improved clarity and consistency.Detailed summary
getThirdwebDomains().bridgewithgetThirdwebBaseUrl("bridge")in thetokensfunction.getThirdwebDomains().bridgewithgetThirdwebBaseUrl("bridge")in theaddfunction.Summary by CodeRabbit