Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Aug 7, 2025


PR-Codex overview

This PR updates the way the base URL for the bridge endpoint is constructed in the Token.ts file. It replaces the usage of getThirdwebDomains with getThirdwebBaseUrl for improved clarity and consistency.

Detailed summary

  • Replaced getThirdwebDomains().bridge with getThirdwebBaseUrl("bridge") in the tokens function.
  • Replaced getThirdwebDomains().bridge with getThirdwebBaseUrl("bridge") in the add function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor
    • Updated internal handling of API endpoint base URLs for improved maintainability. No changes to user-facing features or functionality.

@gregfromstl gregfromstl requested review from a team as code owners August 7, 2025 23:55
@linear
Copy link

linear bot commented Aug 7, 2025

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2025

⚠️ No Changeset found

Latest commit: 9b3fa48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 11:55pm
nebula 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 11:55pm
thirdweb_playground 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 11:55pm
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 11:55pm
wallet-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 11:55pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The change updates how the base URL for bridge token API endpoints is determined in the Token.ts file. It replaces the usage of getThirdwebDomains().bridge with getThirdwebBaseUrl("bridge") for constructing API URLs, affecting both token fetching and addition functions. No other logic or public interfaces are modified.

Changes

Cohort / File(s) Change Summary
Bridge Token API URL Construction
packages/thirdweb/src/bridge/Token.ts
Switched from using getThirdwebDomains().bridge to getThirdwebBaseUrl("bridge") for API endpoints in token-related functions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e114b2c and 9b3fa48.

📒 Files selected for processing (1)
  • packages/thirdweb/src/bridge/Token.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch greg/mny-94-fix-transaction-widget-forcing-payment-even-when-balance-is

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Aug 7, 2025
@gregfromstl gregfromstl merged commit 50c6c19 into main Aug 7, 2025
14 of 20 checks passed
@gregfromstl gregfromstl deleted the greg/mny-94-fix-transaction-widget-forcing-payment-even-when-balance-is branch August 7, 2025 23:55
@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.32%. Comparing base (d812cc3) to head (9b3fa48).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/bridge/Token.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7815      +/-   ##
==========================================
- Coverage   56.33%   56.32%   -0.02%     
==========================================
  Files         905      905              
  Lines       58809    58823      +14     
  Branches     4147     4145       -2     
==========================================
+ Hits        33131    33132       +1     
- Misses      25573    25585      +12     
- Partials      105      106       +1     
Flag Coverage Δ
packages 56.32% <66.66%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
packages/thirdweb/src/bridge/Token.ts 36.36% <66.66%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.15 KB (0%) 1.3 s (0%) 224 ms (+149.35% 🔺) 1.5 s
thirdweb (cjs) 352.97 KB (0%) 7.1 s (0%) 361 ms (+9.24% 🔺) 7.5 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 127 ms (+842.1% 🔺) 241 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 88 ms (+884.62% 🔺) 98 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 104 ms (+290.86% 🔺) 490 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants