Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jul 31, 2025


PR-Codex overview

This PR focuses on enhancing the tokens function in the Token.ts file by adding a chainId parameter and introducing a prices object for each token, which lists prices in multiple currencies.

Detailed summary

  • Added chainId: 1 to the Bridge.tokens call.
  • Updated the token for Ethereum to include a prices object with values for USD, EUR, GBP, and JPY.
  • Updated the token for USD Coin to include a prices object with values for USD, EUR, GBP, and JPY.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Documentation
    • Updated usage examples to include a chainId parameter.
    • Enhanced example token objects to display a new prices field with multiple currency values (USD, EUR, GBP, JPY), while retaining the original priceUsd field for compatibility.

@gregfromstl gregfromstl requested review from a team as code owners July 31, 2025 20:33
@vercel
Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 8:52pm
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 8:52pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 8:52pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 8:52pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 8:52pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The documentation examples for the tokens function in Token.ts were updated to demonstrate the use of a chainId parameter and to show a new prices object in the returned token data. The new prices object includes multiple currency codes, replacing the previous priceUsd field, which is still present for backward compatibility. No logic or implementation changes were made.

Changes

Cohort / File(s) Change Summary
Documentation Example Updates
packages/thirdweb/src/bridge/Token.ts
Updated usage examples for the tokens function to include a chainId parameter and a new prices object in returned token data. The prices object maps currency codes to values, replacing the single priceUsd field (which remains for backward compatibility). No code logic was changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 943cd1b and 367660d.

📒 Files selected for processing (1)
  • packages/thirdweb/src/bridge/Token.ts (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/bridge-tokens-examples

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jul 31, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@gregfromstl gregfromstl force-pushed the fix/bridge-tokens-examples branch from 26ab027 to 367660d Compare July 31, 2025 20:33
@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2025

⚠️ No Changeset found

Latest commit: 367660d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gregfromstl gregfromstl merged commit 6258f74 into main Jul 31, 2025
14 of 19 checks passed
@gregfromstl gregfromstl deleted the fix/bridge-tokens-examples branch July 31, 2025 20:34
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.15 KB (0%) 1.3 s (0%) 482 ms (+49.59% 🔺) 1.8 s
thirdweb (cjs) 353.02 KB (0%) 7.1 s (0%) 2.2 s (+3.67% 🔺) 9.2 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 100 ms (+579.97% 🔺) 213 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 92 ms (+1142.41% 🔺) 102 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 181 ms (+359.22% 🔺) 567 ms

@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.43%. Comparing base (943cd1b) to head (367660d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7771   +/-   ##
=======================================
  Coverage   56.42%   56.43%           
=======================================
  Files         904      904           
  Lines       58674    58674           
  Branches     4139     4139           
=======================================
+ Hits        33108    33113    +5     
+ Misses      25461    25456    -5     
  Partials      105      105           
Flag Coverage Δ
packages 56.43% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
packages/thirdweb/src/bridge/Token.ts 36.36% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants