Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Jul 31, 2025


PR-Codex overview

This PR focuses on enhancing the payment link functionality within the dashboard by adding reporting features for payment link visits and completions, as well as updating component props to include teamSlug and projectSlug.

Detailed summary

  • Added projectSlug and teamSlug props in the page.tsx and RecentPaymentsSection.client.tsx.
  • Updated the Link component to navigate to the payment links page using the new props.
  • Implemented reportPaymentLinkCompleted and reportPaymentLinkVisited functions in the analytics report.
  • Integrated payment link reporting in PayPageWidget.client.tsx and pay/[id]/page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added tracking for payment link visits and completions to enhance analytics.
    • The "Create Payment Link" button now directs users to a team- and project-specific payment links page.
  • Improvements

    • Payment link analytics are now more detailed, with events reported when users visit or complete a payment link.

@gregfromstl gregfromstl requested review from a team as code owners July 31, 2025 19:09
@linear
Copy link

linear bot commented Jul 31, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2025

⚠️ No Changeset found

Latest commit: b9ce392

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 7:23pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jul 31, 2025 7:23pm
nebula ⬜️ Skipped (Inspect) Jul 31, 2025 7:23pm
thirdweb_playground ⬜️ Skipped (Inspect) Jul 31, 2025 7:23pm
wallet-ui ⬜️ Skipped (Inspect) Jul 31, 2025 7:23pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025

Walkthrough

New analytics reporting functions for payment link visits and completions were added. The payment link visit is now tracked in the payment page logic, and payment link completion is tracked upon successful checkout. The "Create Payment Link" button was updated to use dynamic URLs based on team and project slugs, with corresponding prop and usage changes.

Changes

Cohort / File(s) Change Summary
Analytics Reporting Functions
apps/dashboard/src/@/analytics/report.ts
Added reportPaymentLinkVisited and reportPaymentLinkCompleted functions to log payment link visit and completion events.
Recent Payments Section Prop and Link Update
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/components/RecentPaymentsSection.client.tsx
Extended component props to include teamSlug and projectSlug; updated "Create Payment Link" button to use dynamic URL based on these props.
Recent Payments Section Usage Update
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/payments/page.tsx
Passed teamSlug and projectSlug props to RecentPaymentsSection from route params.
Payment Link Visit Analytics
apps/dashboard/src/app/pay/[id]/page.tsx
Imported and invoked reportPaymentLinkVisited after fetching payment link data to log visits.
Payment Link Completion Analytics
apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx
Imported and invoked reportPaymentLinkCompleted in checkout success callback to log completions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PayPage
    participant Analytics
    participant PayPageWidget
    participant CheckoutWidget

    User->>PayPage: Visit /pay/[id]
    PayPage->>Analytics: reportPaymentLinkVisited({linkId, clientId})

    User->>PayPageWidget: Initiate Checkout
    PayPageWidget->>CheckoutWidget: Render
    CheckoutWidget-->>PayPageWidget: onSuccess callback
    PayPageWidget->>Analytics: reportPaymentLinkCompleted({linkId, clientId})
    PayPageWidget->>User: Redirect to success URL
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3ee8f12 and b9ce392.

📒 Files selected for processing (3)
  • apps/dashboard/src/@/analytics/report.ts (1 hunks)
  • apps/dashboard/src/app/pay/[id]/page.tsx (2 hunks)
  • apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/dashboard/src/@/analytics/report.ts
  • apps/dashboard/src/app/pay/[id]/page.tsx
  • apps/dashboard/src/app/pay/components/client/PayPageWidget.client.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Unit Tests
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch greg/mny-63-payment-links-tracking

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 31, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 31, 2025
@codecov
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.42%. Comparing base (ed65f4c) to head (b9ce392).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7769   +/-   ##
=======================================
  Coverage   56.42%   56.42%           
=======================================
  Files         904      904           
  Lines       58674    58674           
  Branches     4139     4139           
=======================================
  Hits        33108    33108           
  Misses      25461    25461           
  Partials      105      105           
Flag Coverage Δ
packages 56.42% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregfromstl gregfromstl force-pushed the greg/mny-63-payment-links-tracking branch from 3ee8f12 to b9ce392 Compare July 31, 2025 19:13
@vercel vercel bot temporarily deployed to Preview – nebula July 31, 2025 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 July 31, 2025 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground July 31, 2025 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui July 31, 2025 19:13 Inactive
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.15 KB (0%) 1.3 s (0%) 595 ms (+149.54% 🔺) 1.9 s
thirdweb (cjs) 353.02 KB (0%) 7.1 s (0%) 2 s (+6.46% 🔺) 9.1 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 316 ms (+1808.36% 🔺) 430 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 181 ms (+3524.5% 🔺) 191 ms
thirdweb/react (minimal + tree-shaking) 19.3 KB (0%) 386 ms (0%) 288 ms (+664.37% 🔺) 674 ms

@gregfromstl gregfromstl merged commit 943cd1b into main Jul 31, 2025
24 checks passed
@gregfromstl gregfromstl deleted the greg/mny-63-payment-links-tracking branch July 31, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants