-
Notifications
You must be signed in to change notification settings - Fork 619
Dashboard: Temporarily remove gas sponsorship option in token creation #7631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Temporarily remove gas sponsorship option in token creation #7631
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
## Walkthrough
The changes disable the gasless transaction feature in both NFT and token launch flows by hardcoding related flags to `false`. Conditional logic and UI sections for gasless sponsorship are removed or bypassed, with TODO comments indicating future re-enablement after bundler updates. No exported or public entity signatures are modified.
## Changes
| File(s) | Change Summary |
|------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------|
| .../tokens/create/nft/launch/launch-nft.tsx<br>.../tokens/create/token/launch/launch-token.tsx | Hardcoded gasless transaction flags to `false`, removed conditional logic and UI for gasless sponsorship, added TODO comments. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant UI
participant GaslessFeature
User->>UI: Initiate token/NFT launch
UI->>GaslessFeature: Check if gasless can be enabled (now always false)
GaslessFeature-->>UI: Return false
UI-->>User: Display launch flow without gasless option |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7631 +/- ##
=======================================
Coverage 56.42% 56.42%
=======================================
Files 906 906
Lines 58126 58126
Branches 4222 4222
=======================================
Hits 32795 32795
Misses 25223 25223
Partials 108 108
🚀 New features to boost your workflow:
|
size-limit report 📦
|
#7631) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on temporarily disabling the gasless feature in two components: `launch-token.tsx` and `launch-nft.tsx`. The condition for enabling gasless functionality has been commented out and replaced with a static `false` value. ### Detailed summary - In `launch-token.tsx`: - `canEnableGasless` is set to `false` with a comment about enabling it later. - `showGaslessSection` is set to `false`. - In `launch-nft.tsx`: - `canEnableGasless` is set to `false` with a comment about enabling it later. - `showGaslessSection` is set to `false`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * The gasless transaction feature and related UI have been temporarily disabled for both NFT and token launch flows. * **Chores** * Updated internal logic to prevent access to the gasless sponsorship section until further notice. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
3b53ac2 to
e125e74
Compare
PR-Codex overview
This PR focuses on disabling gasless functionality in the
launch-token.tsxandlaunch-nft.tsxfiles, with a note indicating that it will be re-enabled later after bundler changes.Detailed summary
In
launch-token.tsx:canEnableGaslessis set tofalsewith a comment about future enabling.showGaslessSectionis set tofalse.In
launch-nft.tsx:canEnableGaslessis set tofalsewith a comment about future enabling.showGaslessSectionis set tofalse.Summary by CodeRabbit