[TOOL-5047] Dashboard: Fix client object missing teamId on contract publish page #7628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
|
""" WalkthroughThe code updates the contract publishing page to use the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PageComponent
participant AuthTokenModule
participant ContractPublishForm
User->>PageComponent: Navigates to publish contract page
PageComponent->>AuthTokenModule: getUserThirdwebClient({ teamId: undefined })
AuthTokenModule-->>PageComponent: Returns client
PageComponent->>ContractPublishForm: Renders with client prop
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
MananTank
added
the
hotfix
Graphite App
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7628 +/- ##
=======================================
Coverage 56.42% 56.42%
=======================================
Files 906 906
Lines 58126 58126
Branches 4222 4222
=======================================
Hits 32795 32795
Misses 25223 25223
Partials 108 108
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Jul 15, 2025
Contributor
Merge activity
|
…ublish page (#7628) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `PublishContractPage` component to utilize the `getUserThirdwebClient` function for client initialization, enhancing user authentication handling during contract publishing. ### Detailed summary - Added import for `getUserThirdwebClient` from `@/api/auth-token`. - Removed import for `getClientThirdwebClient` from `@/constants/thirdweb-client.client`. - Replaced the client initialization in `ContractPublishForm` with `userThirdwebClient` from `getUserThirdwebClient`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Updated the way the client is obtained for the contract publish form, improving consistency in client retrieval. No visible changes to user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
tool-5047
branch
from
3585ebf to
495c7f9
Compare
graphite-app
bot
removed
the
hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates the
PublishContractPageto use thegetUserThirdwebClientinstead of thegetClientThirdwebClient. This change likely aims to enhance user-specific interactions within the contract publishing process.Detailed summary
getUserThirdwebClientfrom@/api/auth-token.getClientThirdwebClientfrom@/constants/thirdweb-client.client.ContractPublishFormwithuserThirdwebClient, initialized withteamId: undefined.Summary by CodeRabbit