chore: add webhook secret to table, fix api error #7606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
WalkthroughThe changes rename the property Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant WebhookConfigModal
participant API
User->>WebhookConfigModal: Submit create/update webhook config
WebhookConfigModal->>API: Send config with topicIdsWithFilters property
API-->>WebhookConfigModal: Respond with result
WebhookConfigModal-->>User: Show status/confirmation
sequenceDiagram
participant User
participant WebhookConfigsTable
User->>WebhookConfigsTable: View list of webhook configs
WebhookConfigsTable->>User: Display table with Webhook Secret column (masked/copyable)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx}Instructions used from: Sources:
apps/{dashboard,playground-web}/**/*.{tsx,ts}Instructions used from: Sources:
🧠 Learnings (4)📓 Common learningsapps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/components/webhook-config-modal.tsx (10)apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/components/webhook-configs-table.tsx (4)apps/dashboard/src/@/api/webhook-configs.ts (4)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
🔇 Additional comments (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7606 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 906 906
Lines 58115 58115
Branches 4226 4226
=======================================
Hits 32810 32810
Misses 25195 25195
Partials 110 110
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
arcoraven
deleted the
ph/07-14-chore_add_webhook_secret_to_table_fix_api_error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Dashboard] Fix: Update webhook API parameter names and add webhook secret display
Notes for the reviewer
This PR updates the webhook configuration API parameter names from
topicstotopicIdsWithFiltersin both the API interface and the components that use it. It also adds a new column to display webhook secrets in the webhook configs table.How to test
Verify that webhook creation and updates work correctly with the renamed parameters, and that webhook secrets are properly displayed in the table with the ability to copy them.
Summary by CodeRabbit
New Features
Refactor