[Portal] Add next button to inner page footers #7605
Merged
+144
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: joaquim.verges <[email protected]>
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
WalkthroughA "Next Page" navigation feature was introduced to the document portal. This includes a utility to find the next page from sidebar links, a button component for navigation, and integration into the page footer. The layout and footer components were updated to support and display this new navigation button. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DocLayout
participant PageFooter
participant AutoNextPageButton
participant getNextPageFromSidebar
participant NextPageButton
User->>DocLayout: Navigates to a document page
DocLayout->>PageFooter: Renders with sidebarLinks
PageFooter->>AutoNextPageButton: Renders with sidebarLinks
AutoNextPageButton->>getNextPageFromSidebar: Find next page (sidebarLinks, currentPath)
getNextPageFromSidebar-->>AutoNextPageButton: Returns next page info or null
alt Next page exists
AutoNextPageButton->>NextPageButton: Render with next page href and name
NextPageButton-->>User: User can click to navigate to next page
else No next page
AutoNextPageButton-->>PageFooter: Renders nothing
end
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
the
Portal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7605 +/- ##
==========================================
- Coverage 56.45% 56.44% -0.01%
==========================================
Files 906 906
Lines 58115 58126 +11
Branches 4226 4228 +2
==========================================
+ Hits 32810 32811 +1
- Misses 25195 25205 +10
Partials 110 110
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
joaquim-verges
changed the title
joaquim-verges
deleted the
cursor/add-next-button-to-inner-page-footers-a0c0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack Thread
Summary by CodeRabbit
PR-Codex overview
This PR introduces a
NextPageButtoncomponent for navigation and anAutoNextPageButtonthat dynamically shows the next page button based on the current path. It also updates thePageFooterto include the new button and modifies the layout and utility functions for sidebar links.Detailed summary
NextPageButtoncomponent for navigation.AutoNextPageButtonto determine the next page based on current path.DocLayoutto includesidebarLinksinPageFooter.PageFooterto conditionally renderAutoNextPageButton.getNextPageFromSidebar.tsfor sidebar link handling.