Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jul 4, 2025


PR-Codex overview

This PR primarily focuses on updating wallet configurations in the thirdweb package by adding new wallets, modifying existing wallet data, and removing obsolete entries. It also includes changes to wallet images and URLs.

Detailed summary

  • Added Frame Wallet to the wallet list.
  • Updated OWallet RDNS value.
  • Set universal URL for YOWallet.
  • Modified Nightly mobile URL.
  • Updated Payperless native URL.
  • Changed OKX Wallet universal URL.
  • Updated image IDs for several wallets.
  • Removed obsolete wallet configurations.
  • Added auto-generated files for new wallets like Frame Wallet, UP.io, TuCOP Wallet, etc.
  • Updated existing wallet image data for various wallets.

The following files were skipped due to too many changes: packages/thirdweb/src/wallets/__generated__/wallet/com.pionewallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bestwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.elrond.maiar.wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.up/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.qubetics/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.blockchain/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/me.rainbow/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bitpay/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.purechain/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/pro.hinkal.walletconnect/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bitcoin/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.kraken/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bifrostwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.kaxaa/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.bitget.web3/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.dcentwallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/com.passwallet.app/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/jp.co.rakuten-wallet/image.ts, packages/thirdweb/src/wallets/__generated__/wallet/io.ibvm/image.ts, packages/thirdweb/src/wallets/__generated__/wallet-ids.ts, packages/thirdweb/src/wallets/__generated__/wallet-infos.ts, packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features
    • Added support for Frame Wallet, including its name, homepage, and icon, to the list of available wallets.

@joaquim-verges joaquim-verges requested review from a team and jnsdls as code owners July 4, 2025 00:19
@vercel
Copy link

vercel bot commented Jul 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 0:43am
nebula ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 0:43am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 0:43am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 0:43am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2025 0:43am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 4, 2025

Warning

Rate limit exceeded

@joaquim-verges has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6a43607 and 7bc29d2.

⛔ Files ignored due to path filters (95)
  • packages/thirdweb/scripts/wallets/extra-wallet-icons/frame.png is excluded by !**/*.png
  • packages/thirdweb/src/wallets/__generated__/getWalletInfo.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet-ids.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet-infos.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/app.nightly/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/app.w3wallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/app.w3wallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/co.arculus/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/co.arculus/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bestwallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bestwallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bifrostwallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bifrostwallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bitcoin/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bitcoin/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bitget.web3/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bitget.web3/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bitpay/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.bitpay/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.blockchain/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.blockchain/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.coinsdo/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.companyname.swaptobe/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.crypto.wallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.dcentwallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.dcentwallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.dokwallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.dokwallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.elrond.maiar.wallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.elrond.maiar.wallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.fireblocks/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.fireblocks/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.gayawallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.gayawallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.gemspocket/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.gemspocket/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.gemwallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.kaxaa/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.kaxaa/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.kraken/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.kraken/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.kucoin/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.ledger/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.obliowallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.obliowallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.okex.wallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.passwallet.app/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.passwallet.app/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.payperless/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.pionewallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.pionewallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.purechain/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.purechain/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.qubetics/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.qubetics/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.revelator.wallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.revelator.wallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.saify/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.saify/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/com.zengo/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/finance.slingshot/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.ancrypto/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.banksocial/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.banksocial/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.ibvm/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.ibvm/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.owallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.up/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.up/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/io.yowallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/jp.co.rakuten-wallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/jp.co.rakuten-wallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/me.rainbow/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/me.rainbow/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/my.mone/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/my.mone/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/one.metapro.wallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/one.mixin.messenger/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/org.creditcoin.app/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/org.creditcoin.app/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/org.rezor/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/org.rezor/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/org.uniswap/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/pro.hinkal.walletconnect/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/pro.hinkal.walletconnect/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/sh.frame/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/sh.frame/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.ctrl/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.ctrl/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.joeywallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.joeywallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.timelesswallet/index.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.tucop/image.ts is excluded by !**/__generated__/**
  • packages/thirdweb/src/wallets/__generated__/wallet/xyz.tucop/index.ts is excluded by !**/__generated__/**
📒 Files selected for processing (2)
  • .changeset/ten-forks-battle.md (1 hunks)
  • packages/thirdweb/scripts/wallets/extra-wallets.json (1 hunks)

Walkthrough

A new entry for "Frame Wallet" was added to the extra-wallets JSON configuration. The entry specifies the wallet's metadata, including its ID, name, homepage, image, and reverse DNS, with all platform-specific URLs set to null.

Changes

File(s) Change Summary
packages/thirdweb/scripts/wallets/extra-wallets.json Added "Frame Wallet" entry with metadata; all URLs null

Suggested labels

packages, SDK


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jul 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 422 ms (+153.74% 🔺) 1.7 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 1.5 s (+0.18% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 124 ms (+821.95% 🔺) 238 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 58 ms (+1343.46% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 75 ms (+158.75% 🔺) 467 ms

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.96%. Comparing base (9f88b5c) to head (7bc29d2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7521   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files         952      952           
  Lines       64224    64224           
  Branches     4237     4238    +1     
=======================================
  Hits        33377    33377           
  Misses      30740    30740           
  Partials      107      107           
Flag Coverage Δ
packages 51.96% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges force-pushed the 07-04-update_wallets_add_sh.frame branch from 6a43607 to 7bc29d2 Compare July 4, 2025 00:33
@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: 7bc29d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/nebula Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants