[TOOL-4908] Dashboard: Fix 'Owner only' claim condition phase type condition #7506

MananTank · 2025-07-02T15:49:45Z

PR-Codex overview

This PR focuses on adding a condition to check if the maxClaimablePerWallet is "0" and enhancing the validation of the phase.snapshot property within the claim-conditions-form component.

Detailed summary

Added a condition to check if phase.maxClaimablePerWallet is "0".
Ensured phase.price is "0".
Checked that phase.snapshot is not a string and has a length of 1.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

Bug Fixes
- Improved claim condition handling to more accurately identify "creator" claim types based on updated criteria.

vercel · 2025-07-02T15:49:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2025 7:20pm

4 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Jul 2, 2025 7:20pm
nebula	⬜️ Skipped (Inspect)	Jul 2, 2025 7:20pm
thirdweb_playground	⬜️ Skipped (Inspect)	Jul 2, 2025 7:20pm
wallet-ui	⬜️ Skipped (Inspect)	Jul 2, 2025 7:20pm

linear · 2025-07-02T15:49:47Z

TOOL-4908 Setting a claim condition price to 0 makes the whole section disappear

changeset-bot · 2025-07-02T15:49:49Z

⚠️ No Changeset found

Latest commit: 84f8043

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-07-02T15:49:51Z

"""

Walkthrough

A stricter condition was added to the getClaimConditionTypeFromPhase function in the claim-conditions-form component. The logic now also checks if maxClaimablePerWallet is exactly "0" (as a string) before returning the "creator" claim condition type, refining the identification of this special case.

Changes

File(s)	Change Summary
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_components/claim-conditions/claim-conditions-form/index.tsx	Added `phase.maxClaimablePerWallet?.toString() === "0"` to the condition in `getClaimConditionTypeFromPhase` function.

Assessment against linked issues

Objective	Addressed	Explanation
Fix disappearing claim condition inputs when price is set to 0 (TOOL-4908)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.
"""

Suggested reviewers

jnsdls

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3f7283 and 84f8043.

📒 Files selected for processing (1)

apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_components/claim-conditions/claim-conditions-form/index.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/_components/claim-conditions/claim-conditions-form/index.tsx

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: Unit Tests
GitHub Check: E2E Tests (pnpm, esbuild)
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: E2E Tests (pnpm, webpack)
GitHub Check: Size
GitHub Check: Lint Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MananTank · 2025-07-02T15:50:01Z

[TOOL-4908] Dashboard: Fix 'Owner only' claim condition phase type condition #7506 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2025-07-02T15:52:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.96%. Comparing base (ac48b24) to head (84f8043).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7506   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files         952      952           
  Lines       64224    64224           
  Branches     4237     4237           
=======================================
  Hits        33377    33377           
  Misses      30740    30740           
  Partials      107      107

Flag	Coverage Δ
packages	`51.96% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-07-02T15:55:00Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	63.11 KB (0%)	1.3 s (0%)	691 ms (+82.88% 🔺)	2 s
thirdweb (cjs)	352.76 KB (0%)	7.1 s (0%)	3.1 s (-2.72% 🔽)	10.2 s
thirdweb (minimal + tree-shaking)	5.72 KB (0%)	115 ms (0%)	87 ms (+205.69% 🔺)	201 ms
thirdweb/chains (tree-shaking)	530 B (0%)	11 ms (0%)	69 ms (+804.85% 🔺)	79 ms
thirdweb/react (minimal + tree-shaking)	19.59 KB (0%)	392 ms (0%)	83 ms (+57.15% 🔺)	475 ms

graphite-app · 2025-07-02T17:58:58Z

Merge activity

Jul 2, 5:58 PM UTC: MananTank added this pull request to the Graphite merge queue.
Jul 2, 6:19 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Unit Tests').
Jul 2, 7:01 PM UTC: MananTank added this pull request to the Graphite merge queue.
Jul 2, 7:20 PM UTC: Merged by the Graphite merge queue.

…ndition (#7506)   --- ## PR-Codex overview This PR focuses on adding a condition to check if `phase.maxClaimablePerWallet` is "0" while ensuring that `phase.snapshot` is not a string and has a length of 1. ### Detailed summary - Added a condition to check if `phase.maxClaimablePerWallet?.toString()` is equal to "0". - Ensured `phase.price` is "0". - Checked that `typeof phase.snapshot` is not a string. - Confirmed `phase.snapshot.length` is equal to 1. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit * **Bug Fixes** * Improved claim condition handling to more accurately identify "creator" claim types based on updated criteria.

…ndition (#7506)   --- ## PR-Codex overview This PR focuses on updating the conditional logic in the `claim-conditions-form` component to include a new check for `phase.maxClaimablePerWallet` when determining the state of the `phase`. ### Detailed summary - Added a condition to check if `phase.maxClaimablePerWallet` is equal to "0" (as a string). - Ensured that `phase.snapshot` is not a string and has a length of 1. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit * **Bug Fixes** * Improved claim condition handling to more accurately identify "creator" claim types based on updated criteria.

…ndition (#7506)   --- ## PR-Codex overview This PR focuses on adding a condition to check if the `maxClaimablePerWallet` is `"0"` and enhancing the validation of the `phase.snapshot` property within the `claim-conditions-form` component. ### Detailed summary - Added a condition to check if `phase.maxClaimablePerWallet` is `"0"`. - Ensured `phase.price` is `"0"`. - Checked that `phase.snapshot` is not a string and has a length of 1. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit * **Bug Fixes** * Improved claim condition handling to more accurately identify "creator" claim types based on updated criteria.

vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 15:49 Inactive

vercel bot temporarily deployed to Preview – nebula July 2, 2025 15:49 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 15:49 Inactive

vercel bot temporarily deployed to Preview – docs-v2 July 2, 2025 15:49 Inactive

github-actions bot assigned MananTank Jul 2, 2025

MananTank marked this pull request as ready for review July 2, 2025 15:49

MananTank requested review from a team as code owners July 2, 2025 15:49

github-actions bot added the Dashboard Involves changes to the Dashboard. label Jul 2, 2025

vercel bot deployed to Preview – thirdweb-www July 2, 2025 15:57 View deployment

jnsdls approved these changes Jul 2, 2025

View reviewed changes

graphite-app bot force-pushed the 07-02-_tool-4908_dashboard_fix_owner_only_claim_condition_phase_type_condition branch from 651c535 to 0bdffce Compare July 2, 2025 18:07

vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 18:08 Inactive

vercel bot temporarily deployed to Preview – docs-v2 July 2, 2025 18:08 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 18:08 Inactive

vercel bot temporarily deployed to Preview – nebula July 2, 2025 18:08 Inactive

graphite-app bot force-pushed the 07-02-_tool-4908_dashboard_fix_owner_only_claim_condition_phase_type_condition branch from 0bdffce to a3f7283 Compare July 2, 2025 18:13

vercel bot temporarily deployed to Preview – docs-v2 July 2, 2025 18:13 Inactive

vercel bot temporarily deployed to Preview – nebula July 2, 2025 18:13 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 18:13 Inactive

vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 18:13 Inactive

vercel bot deployed to Preview – thirdweb-www July 2, 2025 18:23 View deployment

graphite-app bot force-pushed the 07-02-_tool-4908_dashboard_fix_owner_only_claim_condition_phase_type_condition branch from a3f7283 to 84f8043 Compare July 2, 2025 19:11

vercel bot temporarily deployed to Preview – nebula July 2, 2025 19:11 Inactive

vercel bot temporarily deployed to Preview – docs-v2 July 2, 2025 19:11 Inactive

vercel bot temporarily deployed to Preview – wallet-ui July 2, 2025 19:11 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground July 2, 2025 19:11 Inactive

vercel bot deployed to Preview – thirdweb-www July 2, 2025 19:20 View deployment

graphite-app bot merged commit 84f8043 into main Jul 2, 2025
24 checks passed

graphite-app bot deleted the 07-02-_tool-4908_dashboard_fix_owner_only_claim_condition_phase_type_condition branch July 2, 2025 19:20

vercel bot temporarily deployed to Production – wallet-ui July 2, 2025 19:20 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground July 2, 2025 19:20 Inactive

vercel bot temporarily deployed to Production – nebula July 2, 2025 19:20 Inactive

vercel bot temporarily deployed to Production – docs-v2 July 2, 2025 19:20 Inactive

vercel bot deployed to Production – thirdweb-www July 2, 2025 19:28 View deployment

[TOOL-4908] Dashboard: Fix 'Owner only' claim condition phase type condition #7506

[TOOL-4908] Dashboard: Fix 'Owner only' claim condition phase type condition #7506

Uh oh!

Conversation

MananTank commented Jul 2, 2025 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

vercel bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Jul 2, 2025

Uh oh!

changeset-bot bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Suggested reviewers

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

MananTank commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codecov bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

graphite-app bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MananTank commented Jul 2, 2025 •

edited by pr-codex bot

Loading

vercel bot commented Jul 2, 2025 •

edited

Loading

changeset-bot bot commented Jul 2, 2025 •

edited

Loading

coderabbitai bot commented Jul 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

MananTank commented Jul 2, 2025 •

edited

Loading

codecov bot commented Jul 2, 2025 •

edited

Loading

github-actions bot commented Jul 2, 2025 •

edited

Loading

graphite-app bot commented Jul 2, 2025 •

edited

Loading