Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jun 29, 2025


PR-Codex overview

This PR focuses on enhancing the HTTP request headers in the useEmbeddedWallets.ts file by adding a new header for client identification.

Detailed summary

  • Added a new header: x-client-id with the value of clientId to the request headers in the HTTP GET method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Chores
    • Improved request handling by including an additional client identifier in account list fetch requests.

@vercel
Copy link

vercel bot commented Jun 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2025 9:48am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 29, 2025 9:48am
nebula ⬜️ Skipped (Inspect) Jun 29, 2025 9:48am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 29, 2025 9:48am
wallet-ui ⬜️ Skipped (Inspect) Jun 29, 2025 9:48am

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2025

⚠️ No Changeset found

Latest commit: ef9e47f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui June 29, 2025 09:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 June 29, 2025 09:38 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 29, 2025 09:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 29, 2025 09:38 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

An extra HTTP header, "x-client-id", is now included in the fetch request within the fetchAccountList function in the useEmbeddedWallets.ts file. No other logic, error handling, or control flow has been changed.

Changes

File(s) Change Summary
apps/dashboard/src/@/hooks/useEmbeddedWallets.ts Added "x-client-id" header to fetch request in fetchAccountList.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant useEmbeddedWallets
    participant API_Server

    Caller->>useEmbeddedWallets: fetchAccountList(clientId, token)
    useEmbeddedWallets->>API_Server: GET /api/2024-05-05/account/list\nHeaders: Authorization, Content-Type, x-client-id
    API_Server-->>useEmbeddedWallets: Response
    useEmbeddedWallets-->>Caller: Account list data
Loading

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca65b43 and ef9e47f.

📒 Files selected for processing (1)
  • apps/dashboard/src/@/hooks/useEmbeddedWallets.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joaquim-verges joaquim-verges marked this pull request as ready for review June 29, 2025 09:39
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 29, 2025
@joaquim-verges joaquim-verges requested review from a team as code owners June 29, 2025 09:39
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges merged commit fd67c5d into main Jun 29, 2025
21 of 23 checks passed
@joaquim-verges joaquim-verges deleted the _Dashboard_Add_client_ID_header_to_embedded_wallets_fetch_request branch June 29, 2025 09:40
@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (ca65b43) to head (ef9e47f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7471   +/-   ##
=======================================
  Coverage   51.92%   51.92%           
=======================================
  Files         949      949           
  Lines       64149    64149           
  Branches     4228     4228           
=======================================
  Hits        33312    33312           
  Misses      30731    30731           
  Partials      106      106           
Flag Coverage Δ
packages 51.92% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 63.11 KB (0%) 1.3 s (0%) 241 ms (+91.62% 🔺) 1.6 s
thirdweb (cjs) 352.76 KB (0%) 7.1 s (0%) 951 ms (+4.09% 🔺) 8.1 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 70 ms (+867.92% 🔺) 185 ms
thirdweb/chains (tree-shaking) 530 B (0%) 11 ms (0%) 50 ms (+1689.93% 🔺) 61 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 75 ms (+261.02% 🔺) 467 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants