[Dashboard] Update rewrites and redirects for Connect to Build migration #7362
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
WalkthroughThe changes update routing and redirect logic in the dashboard application. Rewrite paths are reorganized by introducing a new "build category" group with several new paths, removing the "/engine" path, and eliminating legacy "/connect" prefixed entries. Redirects are modified by removing some old mappings, changing targets, and adding new reciprocal redirects that align "connect" routes with corresponding "build" routes and introduce a redirect from "/engine" to "/transactions". Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Router
participant Redirects
participant Rewrites
User->>Router: Request /connect/account-abstraction
Router->>Redirects: Check for redirect
Redirects-->>Router: Redirect to /account-abstraction
Router->>Rewrites: Check for rewrite (if applicable)
Rewrites-->>Router: Serve rewritten or redirected content
Router-->>User: Respond with final content
sequenceDiagram
participant User
participant Router
participant Redirects
participant Rewrites
User->>Router: Request /connect
Router->>Redirects: Check for redirect
Redirects-->>Router: Redirect to /wallets
Router->>Rewrites: Check for rewrite (if applicable)
Rewrites-->>Router: Serve rewritten or redirected content
Router-->>User: Respond with final content
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7362 +/- ##
=======================================
Coverage 52.35% 52.36%
=======================================
Files 939 939
Lines 63160 63160
Branches 4215 4216 +1
=======================================
+ Hits 33070 33073 +3
+ Misses 29983 29980 -3
Partials 107 107
🚀 New features to boost your workflow:
|
jnsdls
force-pushed
the
_Dashboard_Update_rewrites_and_redirects_for_Connect_to_Build_migration
branch
from
21cefe4 to
2c5a4bb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/dashboard/framer-rewrites.js (1)
9-18: Re-label legacy Connect paths – they don’t belong in the new “build” blockThe comment banner suggests lines 9-14 are strictly the new Build category, yet the three
/connect/*paths that immediately follow are legacy routes. Mixing them inside the same delimited section will quickly get confusing once more Build pages are added.Consider moving the legacy Connect rewrites below the “end build category” marker (or adding a separate
// -- legacy connect rewritesblock) to keep intent crystal-clear.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/dashboard/framer-rewrites.js(2 hunks)apps/dashboard/redirects.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Analyze (javascript)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
🔇 Additional comments (2)
apps/dashboard/framer-rewrites.js (1)
9-14: Double-check for duplicate rewrites
"/wallets", "/account-abstraction", "/universal-bridge", "/transactions"may already exist elsewhere in this file (e.g. older landing-page entries). Duplicates are harmless at runtime but add noise and invite drift.Run the quick scan:
#!/usr/bin/env bash # list any duplicate literal paths in framer-rewrites rg --fixed-strings -n '"/wallets"' apps/dashboard/framer-rewrites.js rg --fixed-strings -n '"/account-abstraction"' apps/dashboard/framer-rewrites.js rg --fixed-strings -n '"/universal-bridge"' apps/dashboard/framer-rewrites.js rg --fixed-strings -n '"/transactions"' apps/dashboard/framer-rewrites.jsapps/dashboard/redirects.js (1)
366-386: ```shell
#!/usr/bin/env bashLocate any redirects.js file(s) and check for /connect and /engine sources
files=$(fd -t f 'redirects.js')
if [[ -z "$files" ]]; then
echo "ERROR: No redirects.js file found"
exit 1
fifor file in $files; do
echo "Scanning $file"
echo "Occurrences of source "/connect":"
rg --fixed-strings -n '"source": "/connect' "$file" || echo " None"
echo "Occurrences of source "/engine":"
rg --fixed-strings -n '"source": "/engine' "$file" || echo " None"
done</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
size-limit report 📦
|
jnsdls
force-pushed
the
_Dashboard_Update_rewrites_and_redirects_for_Connect_to_Build_migration
branch
from
2c5a4bb to
1bf84f7
Compare
jnsdls
force-pushed
the
_Dashboard_Update_rewrites_and_redirects_for_Connect_to_Build_migration
branch
from
1bf84f7 to
11391c5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jnsdls
force-pushed
the
_Dashboard_Update_rewrites_and_redirects_for_Connect_to_Build_migration
branch
from
11391c5 to
1ed6552
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/dashboard/framer-rewrites.js(2 hunks)apps/dashboard/redirects.js(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/dashboard/framer-rewrites.js
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (javascript)
There was a problem hiding this comment.
Bug: Missing Redirect for Removed Path
The /connect/sign-in path was removed from framer-rewrites.js without a corresponding redirect being added in redirects.js. This is inconsistent with other /connect/* paths that were removed and redirected, causing users accessing /connect/sign-in to receive a 404 error.
apps/dashboard/framer-rewrites.js#L8-L16
js/apps/dashboard/framer-rewrites.js
Lines 8 to 16 in 1ed6552
apps/dashboard/redirects.js#L353-L384
js/apps/dashboard/redirects.js
Lines 353 to 384 in 1ed6552
Bug: Missing Redirect Causes 404 Error
The redirect from /build to /contracts/modular-contracts was removed. As /build was not added to framer-rewrites.js or given a new redirect, accessing this path now results in a 404 error, breaking existing links.
apps/dashboard/redirects.js#L240-L245
js/apps/dashboard/redirects.js
Lines 240 to 245 in 1ed6552
Bug: Missing Redirect for Sign-In Route
The /connect/sign-in route is missing a redirect in redirects.js. While other /connect sub-paths received new redirects, /connect/sign-in was overlooked, leading to a 404 error for users attempting to access it.
apps/dashboard/redirects.js#L353-L384
js/apps/dashboard/redirects.js
Lines 353 to 384 in 1ed6552
Was this report helpful? Give feedback by reacting with 👍 or 👎
jnsdls
deleted the
_Dashboard_Update_rewrites_and_redirects_for_Connect_to_Build_migration
branch
TL;DR
Updated URL structure for product pages, moving Connect-related pages to a new Build category.
What changed?
/wallets,/account-abstraction,/universal-bridge, and/transactionsunder the Build category/connectand/enginefrom Framer rewrites/connect→/build/connect/account-abstraction→/account-abstraction/connect/universal-bridge→/universal-bridge/engine→/transactionsHow to test?
/connectshould redirect to/build/connect/account-abstractionshould redirect to/account-abstraction/connect/universal-bridgeshould redirect to/universal-bridge/engineshould redirect to/transactions/wallets,/account-abstraction, etc.) render correctlyWhy make this change?
Reorganizing the product pages under a more intuitive "Build" category to better represent the product offerings and improve navigation structure. This change maintains backward compatibility through redirects while establishing a clearer information architecture.
PR-Codex overview
This PR focuses on restructuring and updating the routing logic in the
apps/dashboard/framer-rewrites.jsandapps/dashboard/redirects.jsfiles. It replaces old routes with new ones, consolidating the redirects under a "build category" and improving the overall organization of the code.Detailed summary
/connectand its sub-paths./wallets,/account-abstraction,/universal-bridge,/auth,/in-app-wallets, and/transactions./connectprefix./connectand its sub-paths to their new corresponding paths./account-abstraction,/auth, and/in-app-wallets.Summary by CodeRabbit
New Features
Bug Fixes