-
Notifications
You must be signed in to change notification settings - Fork 619
Replace CLI login article link #7355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis change updates URLs in both a redirect configuration and CLI informational messages to point to a new knowledge base article about device link errors with the thirdweb CLI. No other logic, control flow, or exported entity declarations were modified. Changes
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/thirdweb/src/cli/bin.ts (2)
49-52: Duplicate hard-coded URL – extract to a constant to stay DRY.The same portal link is now in at least two places in this file (here and again at L61). Copy-pasting URLs is fragile – the next time it changes we risk missing one location.
+const HELP_URL = + "https://portal.thirdweb.com/knowledge-base/onchain-common-errors/thirdweb-cli/device-link-error"; … - "Please instead pass a secret key to the command directly, learn more: https://portal.thirdweb.com/knowledge-base/onchain-common-errors/thirdweb-cli/device-link-error", + `Please instead pass a secret key to the command directly, learn more: ${HELP_URL}`,Do the same replacement in the default branch below.
60-63: As above – reuse the extracted constant.Once the constant is introduced, replace this literal too:
- "Please include the -k flag with your secret key, learn more: https://portal.thirdweb.com/knowledge-base/onchain-common-errors/thirdweb-cli/device-link-error", + `Please include the -k flag with your secret key, learn more: ${HELP_URL}`,apps/dashboard/redirects.js (1)
212-218: Stale inline comment & potential single-source-of-truth issue.
The preceding comment still says “temporarily redirect cli login to support page”, but the destination is now the portal URL. Update the comment to avoid confusion.
Consider pulling this URL from a shared constant (e.g.,
HELP_URLin a small util module) so the dashboard and CLI stay in sync automatically.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/dashboard/redirects.js(1 hunks)packages/thirdweb/src/cli/bin.ts(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
size-limit report 📦
|
PR-Codex overview
This PR focuses on updating URLs in the
apps/dashboard/redirects.jsandpackages/thirdweb/src/cli/bin.tsfiles to point to a new knowledge base page related to troubleshooting device linking errors in thethirdweb-cli.Detailed summary
sourceanddestinationURLs inapps/dashboard/redirects.jsto point to the new knowledge base page.packages/thirdweb/src/cli/bin.tsto reflect the new URL for troubleshooting device linking errors.-kflag inpackages/thirdweb/src/cli/bin.ts.Summary by CodeRabbit