-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Fix: Handle ping event #7287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe update introduces handling for a new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant promptNebula
Client->>promptNebula: Send event
alt Event is "ping"
promptNebula-->>Client: (No action taken)
else Other events
promptNebula-->>Client: Handle event as before
end
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7287 +/- ##
=======================================
Coverage 55.58% 55.58%
=======================================
Files 909 909
Lines 58670 58670
Branches 4158 4158
=======================================
Hits 32609 32609
Misses 25954 25954
Partials 107 107
🚀 New features to boost your workflow:
|
size-limit report 📦
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
This PR adds a simple `ping` case in the `promptNebula` function to avoid `console.warn` logs in the browser console.
<!-- start pr-codex -->
---
## PR-Codex overview
This PR adds support for a new event type, `"ping"`, in the `ChatStreamedEvent` type definition and handles the `"ping"` event case in the event processing logic.
### Detailed summary
- Added a new case for `"ping"` in the event handling switch statement.
- Introduced a new type definition for the `"ping"` event in the `ChatStreamedEvent` type, including a `data` field of type `string`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **New Features**
- Improved chat event handling with support for a new "ping" event type, enhancing the stability of real-time chat updates.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
03d0497 to
5c4c49b
Compare
This PR adds a simple
pingcase in thepromptNebulafunction to avoidconsole.warnlogs in the browser console.PR-Codex overview
This PR introduces a new event type for the chat API, specifically handling a "ping" event.
Detailed summary
"ping"event in the switch statement."ping"event in theChatStreamedEventtype, which now includes adatafield of typestring.Summary by CodeRabbit