Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 14, 2025


PR-Codex overview

This PR focuses on enhancing the UI components of the nebula-app by modifying layouts, adding new features, and improving the interaction with wallet and asset management functionalities.

Detailed summary

  • Changed mergedSessions.push(session) to mergedSessions.unshift(session) in useSessionsWithLocalOverrides.ts.
  • Updated width from 280px to 300px in ChatPageLayout.tsx.
  • Added customDetailsButton prop in NebulaConnectWallet component.
  • Implemented new story setups for AssetsSection and TransactionsSection in Storybook.
  • Enhanced AssetsSection and TransactionsSection components with new functionalities and UI elements.
  • Refactored WalletSelector to include wallet details and improved accessibility features.
  • Added WalletDetails component in ChatSidebar for displaying assets and transactions.
  • Improved CustomConnectButton to dynamically render wallet information.
  • Updated various UI elements for better user experience and consistency.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 9:54pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 14, 2025 9:54pm
login ⬜️ Skipped (Inspect) May 14, 2025 9:54pm
thirdweb_playground ⬜️ Skipped (Inspect) May 14, 2025 9:54pm
wallet-ui ⬜️ Skipped (Inspect) May 14, 2025 9:54pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 15:52 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 15:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 14, 2025 15:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 15:52 Inactive
@linear
Copy link

linear bot commented May 14, 2025

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: dfa8603

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review May 14, 2025 15:52
@MananTank MananTank requested review from a team as code owners May 14, 2025 15:52
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 14, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [NEB-213] Show wallet Assets in sidebar [NEB-213] Nebula: Show wallet Assets in sidebar May 14, 2025
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (9f1ca54) to head (dfa8603).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7046   +/-   ##
=======================================
  Coverage   55.51%   55.51%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4071     4071           
=======================================
  Hits        32419    32419           
  Misses      25878    25878           
  Partials      105      105           
Flag Coverage Δ
packages 55.51% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 221 ms (+211.55% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 412 ms (+56.24% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 115 ms (+2246.05% 🔺) 229 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 44 ms (+1522.2% 🔺) 54 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 89 ms (+603.44% 🔺) 480 ms

@MananTank MananTank marked this pull request as draft May 14, 2025 17:50
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 14, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 18:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 18:48 Inactive
@MananTank MananTank marked this pull request as ready for review May 14, 2025 18:56
@MananTank MananTank changed the title [NEB-213] Nebula: Show wallet Assets in sidebar [NEB-213] Nebula: Show wallet Assets and Activity in sidebar May 14, 2025
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 19:06 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 14, 2025 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 19:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 14, 2025 19:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 19:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 19:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 14, 2025 19:59 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 19:59 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented May 14, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on enhancing the `AssetsSection` and `TransactionsSection` components by adding new features and improving the UI. It also modifies several existing components for better functionality and user experience.

### Detailed summary
- Changed `mergedSessions.push(session)` to `mergedSessions.unshift(session)` in `useSessionsWithLocalOverrides.ts`.
- Updated the width of the sidebar in `ChatPageLayout.tsx` from `280px` to `300px`.
- Added `customDetailsButton` prop to `NebulaConnectWallet` in `NebulaConnectButton.tsx`.
- Implemented conditional rendering for `customDetailsButton` in `NebulaConnectWallet`.
- Created storybook stories for `AssetsSection` and `TransactionsSection` with stubs for tokens and transactions.
- Enhanced `AssetsSection` and `TransactionsSection` components to handle loading states and display messages when there are no assets or transactions.
- Introduced `WalletDetails` component in `ChatSidebar` to manage assets and transactions tabs.
- Refactored `WalletSelector` to integrate `useActiveWallet` for better wallet management and user feedback.
- Improved button components with tooltips for better accessibility and UX.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 14, 2025 21:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 14, 2025 21:47 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 14, 2025 21:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 14, 2025 21:47 Inactive
@graphite-app graphite-app bot merged commit dfa8603 into main May 14, 2025
23 checks passed
@graphite-app graphite-app bot deleted the neb-213 branch May 14, 2025 22:33
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 14, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Production – login May 14, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 14, 2025 22:33 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 May 14, 2025 22:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants