Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 12, 2025


PR-Codex overview

This PR focuses on enhancing the billing and plan features within the application, including UI adjustments, adding new props for plan management, and refining tooltip content for better user guidance.

Detailed summary

  • Updated sideOffset in tooltip.tsx for styling.
  • Changed requiredPlan from authRequiredPlan to brandingRequiredPlan in index.tsx.
  • Added openPlanSheetButtonByDefault and highlightPlan props in several components.
  • Adjusted PlanInfoCardClient and Billing components to utilize new props.
  • Modified plan badge labels and styles in TeamPlanBadge.tsx.
  • Enhanced BillingPricing logic to incorporate highlightPlan.
  • Updated GatedSwitch to improve tooltip display and upgrade prompts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented May 12, 2025

@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 19:13 Inactive
@vercel
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 8:29pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 13, 2025 8:29pm
login ⬜️ Skipped (Inspect) May 13, 2025 8:29pm
thirdweb_playground ⬜️ Skipped (Inspect) May 13, 2025 8:29pm
wallet-ui ⬜️ Skipped (Inspect) May 13, 2025 8:29pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 12, 2025 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 19:13 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

⚠️ No Changeset found

Latest commit: 04c10f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review May 12, 2025 19:13
@MananTank MananTank requested review from a team as code owners May 12, 2025 19:13
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 12, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (ab17388) to head (04c10f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7021   +/-   ##
=======================================
  Coverage   54.89%   54.89%           
=======================================
  Files         909      909           
  Lines       58396    58396           
  Branches     4035     4035           
=======================================
  Hits        32056    32056           
  Misses      26235    26235           
  Partials      105      105           
Flag Coverage Δ
packages 54.89% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 12, 2025 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 19:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 19:16 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 163 ms (+98.08% 🔺) 1.3 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 325 ms (+23.34% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 75 ms (+1312.06% 🔺) 188 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 30 ms (+835.05% 🔺) 40 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 76 ms (+421.46% 🔺) 466 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented May 13, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request May 13, 2025
… starter+ (#7021)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the billing and plan management features in the dashboard. It introduces new props for handling plan visibility and highlights, updates tooltip styles, and modifies the UI to support new plan requirements and features.

### Detailed summary
- Updated `tooltip.tsx` to adjust padding in the tooltip component.
- Changed `requiredPlan` from `authRequiredPlan` to `brandingRequiredPlan` in `Configure/index.tsx`.
- Added `openPlanSheetButtonByDefault` and `highlightPlan` props to several components.
- Modified `PlanInfoCardClient` and `Billing` components to utilize new props.
- Updated plan badge color for `starter` to `warning`.
- Made `getTeamPlanBadgeLabel` function exportable.
- Enhanced `PlanInfoCard` and `ViewPlansSheet` components to accept new props.
- Adjusted `BillingPricing` logic to highlight plans based on new props.
- Updated `GatedSwitch` to display upgraded plan information with improved tooltip content.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 13, 2025 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 13, 2025 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 13, 2025 18:18 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 13, 2025 18:18 Inactive
… starter+ (#7021)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the billing and plan management features in the dashboard. It introduces new props for handling plan highlights and open plan sheets, modifies tooltip styles, and adjusts billing card components to improve user experience.

### Detailed summary
- Updated `tooltip.tsx` to change padding in tooltip content.
- Changed `requiredPlan` from `authRequiredPlan` to `brandingRequiredPlan` in `Configure/index.tsx`.
- Added `openPlanSheetButtonByDefault` and `highlightPlan` props in various components.
- Modified `PlanInfoCardClient` and `Billing` components to utilize new props.
- Updated `TeamPlanBadge` to include an optional postfix.
- Enhanced `BillingPricing` logic to handle plan highlights.
- Adjusted `GatedSwitch` tooltip content for better user guidance.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login May 13, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 13, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 13, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 13, 2025 20:22 Inactive
@graphite-app graphite-app bot merged commit 04c10f8 into main May 13, 2025
23 checks passed
@graphite-app graphite-app bot deleted the tool-4471 branch May 13, 2025 20:30
@vercel vercel bot temporarily deployed to Production – login May 13, 2025 20:30 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 13, 2025 20:30 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 13, 2025 20:30 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 May 13, 2025 20:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants