Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented May 12, 2025

Closes TOOL-4446


PR-Codex overview

This PR focuses on enhancing documentation related to the SignAuthorization feature and Native Account Abstraction in the thirdweb framework, providing clearer explanations and examples for developers.

Detailed summary

  • Updated the name of SignAuthorization in sidebar.tsx.
  • Revised documentation in page.mdx files to clarify Native Account Abstraction and provide detailed code examples.
  • Added explanations of execution modes for InAppWallet.
  • Included new onramping functionality with Fiat in universal-bridge documentation.
  • Changed the description of SignAuthorization integration to emphasize low-level API usage.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper requested review from a team as code owners May 12, 2025 14:41
@vercel
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 11:17pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 12, 2025 11:17pm
thirdweb_playground ⬜️ Skipped (Inspect) May 12, 2025 11:17pm
thirdweb-www ⬜️ Skipped (Inspect) May 12, 2025 11:17pm
wallet-ui ⬜️ Skipped (Inspect) May 12, 2025 11:17pm

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

⚠️ No Changeset found

Latest commit: 49de018

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented May 12, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label May 12, 2025
@linear
Copy link

linear bot commented May 12, 2025

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.90%. Comparing base (1985de8) to head (49de018).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7017   +/-   ##
=======================================
  Coverage   54.90%   54.90%           
=======================================
  Files         909      909           
  Lines       58374    58374           
  Branches     4034     4034           
=======================================
  Hits        32051    32051           
  Misses      26218    26218           
  Partials      105      105           
Flag Coverage Δ
packages 54.90% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 224 ms (+120.09% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 501 ms (+20.14% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 58 ms (+294.54% 🔺) 172 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 20 ms (+894.36% 🔺) 30 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 69 ms (+214.53% 🔺) 460 ms

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 12, 2025 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 12, 2025 14:54 Inactive
@0xFirekeeper 0xFirekeeper added the merge-queue Adds the pull request to Graphite's merge queue. label May 12, 2025
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 14:54 Inactive
Copy link
Member Author

0xFirekeeper commented May 12, 2025

Merge activity

  • May 12, 10:54 AM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 12, 7:07 PM EDT: 0xFirekeeper added this pull request to the Graphite merge queue.
  • May 13, 12:08 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 12, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 14:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 14:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 14:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 14:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 12, 2025 14:55 Inactive
… Abstraction (#7017)

Closes TOOL-4446

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating documentation and examples related to `SignAuthorization` and `Native Account Abstraction`, enhancing clarity and functionality descriptions, and introducing new features for integrating with Ethereum's EIP-7702 and EIP-4337 standards.

### Detailed summary
- Updated `name` in `sidebar.tsx` from "SignAuthorization (Experimental)" to "SignAuthorization".
- Revised documentation in `page.mdx` files to clarify `Native Account Abstraction`.
- Added examples for creating and using `InAppWallet` with EIP-7702.
- Introduced details on `ExecutionMode` options for account abstraction.
- Enhanced `Onramping with Fiat` section with new code examples.
- Updated `SignAuthorization` section to reflect low-level API usage and parameters.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the firekeeper/dotnet-onramp-7702 branch from ab008f3 to 49de018 Compare May 12, 2025 23:07
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 12, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 23:07 Inactive
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label May 13, 2025
@joaquim-verges joaquim-verges merged commit 1c31a1e into main May 13, 2025
23 checks passed
@joaquim-verges joaquim-verges deleted the firekeeper/dotnet-onramp-7702 branch May 13, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants