Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 2, 2025


PR-Codex overview

This PR primarily focuses on enhancing the ChatPageContent and RenderMessage components by modifying how messages are processed and sent, particularly in relation to the presence of subsequent messages.

Detailed summary

  • Removed logic that removed the last message if it was of type presence in ChatPageContent.
  • Added nextMessage prop to RenderMessage to reference the following message.
  • Updated onTxSettled to prevent sending automatic prompts if the next message is of type action.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 3:03pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 2, 2025 3:03pm
login ⬜️ Skipped (Inspect) May 2, 2025 3:03pm
thirdweb_playground ⬜️ Skipped (Inspect) May 2, 2025 3:03pm
wallet-ui ⬜️ Skipped (Inspect) May 2, 2025 3:03pm

@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 12:35 Inactive
@linear
Copy link

linear bot commented May 2, 2025

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 12:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 12:35 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 1e82083

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review May 2, 2025 12:35
@MananTank MananTank requested review from a team as code owners May 2, 2025 12:35
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 2, 2025
Copy link
Member Author

MananTank commented May 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [NEB-229] Nebula: Do not send follow-up prompt if there's another tx to be executed after current tx [NEB-229] Nebula: follow-up prompt improvements, preserve reasoning UI on error May 2, 2025
@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.03%. Comparing base (20d182b) to head (1e82083).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6925   +/-   ##
=======================================
  Coverage   55.03%   55.03%           
=======================================
  Files         897      897           
  Lines       57296    57296           
  Branches     3959     3959           
=======================================
  Hits        31530    31530           
  Misses      25670    25670           
  Partials       96       96           
Flag Coverage Δ
packages 55.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.93 KB (0%) 1.1 s (0%) 625 ms (+78.86% 🔺) 1.7 s
thirdweb (cjs) 143.02 KB (0%) 2.9 s (0%) 1.1 s (+40.39% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 262 ms (+766.49% 🔺) 376 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 150 ms (+1972.23% 🔺) 160 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 325 ms (+535.18% 🔺) 715 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented May 2, 2025

Merge activity

…I on error (#6925)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ChatPageContent` and `Chats` components by managing message handling and improving the logic for sending prompts based on the presence of subsequent messages.

### Detailed summary
- Removed logic to delete the last message if it is of type `presence` in `ChatPageContent.tsx`.
- Added `nextMessage` prop to `RenderMessage` in `Chats.tsx`.
- Updated `onTxSettled` to prevent sending prompts if the `nextMessage` is of type `action`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 2, 2025 14:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 2, 2025 14:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 2, 2025 14:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 2, 2025 14:56 Inactive
@graphite-app graphite-app bot merged commit 1e82083 into main May 2, 2025
23 checks passed
@graphite-app graphite-app bot deleted the neb-229 branch May 2, 2025 15:03
@vercel vercel bot temporarily deployed to Production – wallet-ui May 2, 2025 15:03 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 May 2, 2025 15:03 Inactive
@vercel vercel bot temporarily deployed to Production – login May 2, 2025 15:03 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 2, 2025 15:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants