Added ability to use SecurePay's stored card functions using createCard/updateCard/deleteCard #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can add a card use createCard() - Cad edit an existing card using updateCard() - Can delete a stored card using deleteCard() All options require a 'cardReference' parameter to work. * Added a check to purchase() to see if the user is sending a cardReference, then processes the payment via the credit card associated to the cardReference if there is one. * Fixed some tests that appear to be no longer working (invalid headers. missing mocked data) * Changed the API version to a variable as the standard XML API uses 'xml-4.2' and stored card functions use 'spxml-4.2'
|
Sorry there was some weirdness in some of the mocked responses that were fine on mine but were downloading as symlinks on others. Deleted and re-added them and fine now! |
|
@barryvdh is there any reason why this feature request can not be merged into a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team
Added the ability to use the card storage functions in secure pay and modified the purchase method to see the cardReference in the attributes and use the stored card purchase method instead. Uses the existing updateCard/deleteCard/createCard syntax that Omnipay requires.
Also fixed some of the tests that were failing and added new ones to test stored card functions.
I fixed up the line endings so they are all normalised and add a .gitattribute the force 'lf' endings!