-
Notifications
You must be signed in to change notification settings - Fork 9
New Netbanx Hosted Payments API Support #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Netbanx Hosted Payments API Support #4
Conversation
The start of the new hosted gateway API support. Tests for capture and refund success and failure needed.
@greydnls once I get tests for refund and capture, as well as code formatting passing on travisCI, would you be the person to merge? |
The official maintainer for this gateway is @borNfreee although any of the omnipay team can do the merge. |
thanks @delatbabel will ping once ready. |
This is my first time building a 'full' omnipay gateway, feedback welcome @borNfreee |
@@ -0,0 +1,9 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should not commit any .idea/* files to this repository. Remove them please
@lukeholder Hello, I'm not a maintainer of this NetBanx omnipay repository, I'm just a person who created it initialy without commit/merge access. In general, you PR looks good but please ping the real maintainer |
Ping @barryvdh -- the omnipay repository has @borNfreee listed as the maintainer but I guess that should switch to one of the Omnipay team. Do you want to pick it up? NetBanx is EU so I guess closer to your sphere of influence than mine. @borNfreee thanks for your work + code analysis. |
@delatbabel To be honest, I never heard of this gateway and have no way of testing. I'd rather make @borNfreee or @lukeholder a maintainer, as they both use it and clearly do have knowledge about this gateway. What do you think? |
@barryvdh happy to put my hand up |
Clearly showing insufficient reluctance. |
switched to new branch name so I can composer install my fork, so new pull request: |
Added support for the new Netbanx (Optimal Payments / Paysafe) Hosted Payments gateway API support.
Supports:
All new Netbanx customers are not allowed to use the old API anymore.
API Docs: https://developer.optimalpayments.com/en/documentation/hosted-payment-api/overview/
Tests for
capture()
andrefund()
(success and failure casses) still needed.